Andreas Klöckner authored 10 months ago and Andreas Klöckner committed 9 months ago

Also, refactor test MeshBuilder to not pretend to act as source of
truth on mesh order.

* Handle use-before-assign warnings from pylint

* fix remaining flake8, pylint errors

---------

Co-authored-by: Matthias Diener <mdiener@illinois.edu>

Andreas Klöckner authored 11 months ago and Andreas Klöckner committed 11 months ago

x-ref: https://github.com/inducer/meshmode/issues/403

* support empty groups in reductions

* simplify conditional

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* don't set a default initial value in nodal_min/nodal_max

* test with and without initial value

* Revert "don't set a default initial value in nodal_min/nodal_max"

This reverts commit 771fb7bab3a18e64248fe7725f53c77a48ef6ae6.

decided against this; not setting an initial value means that initial
value always needs to be passed in multi-volume case

* add test case for empty + no initial value

Co-authored-by: Andreas Klöckner <inform@tiker.net>

Andreas Klöckner authored 2 years ago and Andreas Klöckner committed 2 years ago

As requested by @matthiasdiener in
https://github.com/inducer/grudge/pull/249#pullrequestreview-933685048

Andreas Klöckner authored 2 years ago and Andreas Klöckner committed 2 years ago

Fixes https://github.com/inducer/grudge/pull/248/

x-ref: https://github.com/inducer/grudge/pull/247#discussion_r843447075