raphTec authored May 12, 2023 and Andreas Klöckner committed Sep 17, 2023

After executing a command, immediatly hitting the arrow up key should
recall the just executed command again, like in all shells.
This commit ensures this behavior by clearing out the saved edit text on
successful command execution.

Previously, it recalled the last saved edit text if set, which is an
annoying workflow break compared to other shells.

raphTec authored May 12, 2023 and Andreas Klöckner committed Sep 17, 2023

There is the
- command history, which stores previously executed commands
- result scrollback, which refers to list of shell prompts and their
  results

The latter one was previously called 'command line history'.
To avoid confusion, this commit introduces a major new term.

raphTec authored May 12, 2023 and Andreas Klöckner committed Sep 17, 2023

This changes the arow keys from accessing the command line results to
browsing the command history, as requested by the main developer:
https://github.com/inducer/pudb/pull/600#issuecomment-1532444371

raphTec authored Apr 26, 2023 and Andreas Klöckner committed Sep 17, 2023

Text input to the internal command line is now restored and not lost
after browsing the history. It is designed to behave just like a
dedicated history item at the end of the history. This matches the
behavior of readline in most shells.
For example, writing a command without executing it, then moving up to
the most recent history item and down again restores the typed command.

The pudb special behavior of clearing the command when moving down from
the end of the history is also preserved. In that case the text can be
restored too by moving up in the history again before typing anything
new.
This is akin to using Ctrl-C in common shells to clear the current
command, but with the ability to restore the input again.

Using the clear button which empties the displayed shell history now
also clears the command input, since it can be easily restored.

This fixes one of my pain points with the internal pudb command line:
When writing a lengthy command, accidentally hitting Ctrl-N or Ctrl-P
overwrites the input text field with no possibility to get the content
back.
This is particularly bad after using vim's word completion with Ctrl-N
for an extensive amount of time, and then accidentally hitting the same
shortcut in pudb instead of tab completion.

raphTec authored Apr 25, 2023 and Andreas Klöckner committed Sep 17, 2023

A deque handles the size limit internally, eliminating some logic in the
debugger itself.

https://github.com/inducer/pudb/pull/603

raphTec authored Apr 25, 2023 and Andreas Klöckner committed Apr 30, 2023

This function may cause an import cycle when it is called during early
startup.
Specifically, during import of debugger.py, the settings are loaded.
Exceptions during load are forwarded to the logging system, where they
are handled by TerminalOrStreamHandler. This is turn will call
_have_debugger() to determine whether to display an UI dialog.
The function attempts to import debugger.py, completing the import cycle.

Wu Zhenyu authored Mar 06, 2023 and Andreas Klöckner committed Mar 06, 2023

Support completing python modules

* Start implementing jump command

Right now it doesn't stop on the line (like t), which would be ideal. I can't
figure out how to make it do that. pdb's j does it, so it should be possible.

It also isn't documented or heavily tested yet.

See issue #129.

* Fix function name that has changed

* Fix the jump command

We need to update the UI manually as end() will run past the current line.
Also, setting a temporary breakpoint is unnecessary.

* Fix keyboard help for jump

* Fix flake8 issues

Co-authored-by: Andreas Klöckner <inform@tiker.net>

Cibin Mathew authored Apr 28, 2022 and Andreas Klöckner committed Jan 01, 2023

Fixes: https://github.com/inducer/pudb/issues/507

Michael van der Kamp authored Nov 18, 2022 and Andreas Klöckner committed Nov 19, 2022

    - Also continue to show the error message in the ui_log

kwmiebach authored Nov 07, 2022 and Andreas Klöckner committed Nov 07, 2022

Being more specific about which keys adjust width or height.
See also https://stackoverflow.com/a/64482286

* Revert "Remaster midnight theme for hierarchical styles"

This reverts commit c7a8fbb0.

* Clean up some of the colors in the midnight theme

- Add some colors for some extra Python tokens
- Make the current line easier to see
- Add back the link() calls from the reverted c7a8fbb0 (although I'm unsure
  what they do)

* Make the command line not bold in the midnight theme

* Use the default text color in the midnight theme

The theme claims to be best with green text, so we also use white instead of
green for the comment color.

* More cleanups to the midnight theme

- Make the highlighted line always blue instead of green
- Fix some color combinations that were hard to read
- Be consistent about highlighted and active things in the sidebar. Active is
  bold, highlighted is blue background, disabled is gray. In the variables
  view green (and lighter green for highlighted) is used for highlighted
  variables.
- Use lighter and darker yellow (actually brown and yellow) for the current
  line highlighted and not highlighted.
- Make the sidebars lighter when selected
- Make the hotkeys italics as well as underlined, since the underline is very
  hard to see

Some issues:

- The bold dark gray for disabled highlighted breakpoints is just showing as
  bold white. Don't know if that's a bug in my terminal or a bug in urwid, or
  if they really do just look the same.
- The hotkey letter in the highlighted pane does not change. Should there be a
  "focused hotkey" color?

* Fix flake8 issues

* Make some changes to the midnight theme from the review by @mvanderkamp

* Use light green as the main color for midnight instead of dark green

* Color operators in dark green in the midnight theme

* Some tweaks to the midnight theme based on review

* Get rid of some redundant settings in the midnight theme