Kaushik Kulkarni authored 3 years ago and Andreas Klöckner committed 2 years ago

Co-authored-by: Matthias Diener <mdiener@illinois.edu>
Co-authored-by: Andreas Kloeckner <inform@tiker.net>

Kaushik Kulkarni authored 3 years ago and Andreas Klöckner committed 2 years ago

Co-authored-by: Matt Smith <majosm@illinois.edu>
Co-authored-by: Andreas Kloeckner <inform@tiker.net>

* support empty groups in reductions

* simplify conditional

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* don't set a default initial value in nodal_min/nodal_max

* test with and without initial value

* Revert "don't set a default initial value in nodal_min/nodal_max"

This reverts commit 771fb7bab3a18e64248fe7725f53c77a48ef6ae6.

decided against this; not setting an initial value means that initial
value always needs to be passed in multi-volume case

* add test case for empty + no initial value

Co-authored-by: Andreas Klöckner <inform@tiker.net>

Matt Smith authored 2 years ago and Andreas Klöckner committed 2 years ago

This reverts commit 47d2d6b0dc76bdc01be7168cc79e13da72540820.

Andreas Klöckner authored 2 years ago and Andreas Klöckner committed 2 years ago

As requested by @matthiasdiener in
https://github.com/inducer/grudge/pull/249#pullrequestreview-933685048

Andreas Klöckner authored 2 years ago and Andreas Klöckner committed 2 years ago

Fixes https://github.com/inducer/grudge/pull/248/

Andreas Klöckner authored 2 years ago and Andreas Klöckner committed 2 years ago

x-ref: https://github.com/inducer/arraycontext/pull/153

x-ref: https://github.com/inducer/grudge/pull/247#discussion_r843447075