* support empty groups in reductions

* simplify conditional

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* don't set a default initial value in nodal_min/nodal_max

* test with and without initial value

* Revert "don't set a default initial value in nodal_min/nodal_max"

This reverts commit 771fb7bab3a18e64248fe7725f53c77a48ef6ae6.

decided against this; not setting an initial value means that initial
value always needs to be passed in multi-volume case

* add test case for empty + no initial value

Co-authored-by: Andreas Klöckner <inform@tiker.net>

Matt Smith authored 2 years ago and Andreas Klöckner committed 2 years ago

This reverts commit 47d2d6b0dc76bdc01be7168cc79e13da72540820.

Andreas Klöckner authored 2 years ago and Andreas Klöckner committed 2 years ago

As requested by @matthiasdiener in
https://github.com/inducer/grudge/pull/249#pullrequestreview-933685048

Andreas Klöckner authored 2 years ago and Andreas Klöckner committed 2 years ago

Fixes https://github.com/inducer/grudge/pull/248/

Andreas Klöckner authored 2 years ago and Andreas Klöckner committed 2 years ago

x-ref: https://github.com/inducer/arraycontext/pull/153

x-ref: https://github.com/inducer/grudge/pull/247#discussion_r843447075

* get_reasonable_array_context_class improvements
- add documentation
- add logging
- check for correct loopy branch

* reword doc

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* clarify which branches are needed

* add warning about missing branches

* check for mismatched loopy/meshmode branches

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* also test mirgecom examples in CI

* reorder

* also test production

* remove production test (won't work without emirge)

* only test examples for mirgecom

* return a radius, not a diameter

* add comment

Mike Campbell authored 3 years ago and Andreas Klöckner committed 3 years ago

It is OK to use COMM_WORLD here, and this continues to work even for array contexts that don't have the mpi_communicator attribute.  This fixes many failing tests in MIRGE-Com.

* use hash of comm_tag if not numeric

* Drop comm_tag_to_mpi_tag

* modulo tag_ub

* flake8

* use actx mpi_comm

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* User persistent_dict hashing to guess a tag

Co-authored-by: Andreas Kloeckner <inform@tiker.net>

* Boundary lazy comm v2

* fixes

* use pytato branch

* use staple_distributed_send

* add lazy option to wave-op-mpi

* ci fix

* initial actx support

* _RankBoundaryCommunicationLazy: do not convert to/from numpy, flatten

* Prototype MPIPytatoPyOpenCLArrayContext

* Drop evt.wait in distributed actx

* cross_rank_trace_pairs: set 'unique' tag per obj array component

* Drop commented-out graph vis from mpi+lazy actx

* add clone()

* only use Lazy boundary comm when running with lazy actx

* fix git branch

* remove duplicate requirement

* accept distributed+parallel actx

* wave-op-mpi: add simple timing

* fix MPISingleGridWorkBalancingPytatoArrayContex

* fix spelling

* initial lazy batched comm

* select comm class based on actx

* flake8

* use meshmode lazy actx

* test: use random tag

* undo random tag change

* use random tag again

* another tag fix

* debug tracepair

* add dbg

* more dbg

* Use structured tags for lazily-communicated array containers

* MPISingleGridWorkBalancingPytatoArrayContext: Convert symbolic to numeric comm tags

* more type annotation

* support running eager comm as well

* force SingleGridWorkBalancingPytatoArrayContext

* wave-op-mpi: Fix name of MPI+Pytato array context

* wave-op-mpi: Add missing mpi_communicator arg to DiscretizationCollection

* Distributed actx: deduplicate data wrappers before partitioning

* undo pytato branch

* add loopy req

* test with MPI

* use serial actx if parallel not available

* rework dependency chain

* fix lint

* make wave-op-mpi run without older lazy actx

* adapt to recent arraycontext changes

* use DistributedLazyArrayContext to simplify lazy detection

* document tag arg

* Simplify distributed-lazy array context usage (#218)

* add get_reasonable_array_context_class

* add get_reasonable_array_context_class

* document tag in interior_trace_pairs

* update MPI test infrastructure

* restructure tests

* Weak wave operator: add comm tag

* Generalize MPI test orchestration for lazy

* MPI test: use actx.compile

* test fixes

* fix sin()

* Drop leap from test_mpi_communication

* Add norm assert to test_mpi_communication

* restore final_t

* Introduce an eager-MPI array context with a sym->num tag map

Co-authored-by: Andreas Kloeckner <inform@tiker.net>

* Add Euler module

* Add simple vortex example

* Document Euler operator and add pulse experiment

* Test euler examples in lazy mode

* Make rk4_step importable

* Remove copypasta from example headers

* Make vortex initial condition importable

* Add Euler convergence test to test suite

* Rename: EulerContainer -> EulerField

* Clean up vortex initial condition

* Add type annotations and rename array container

* Clean up helper functions

* Add Euler module to the docs

* Force a single-value per element for elementwise reductions when applicable

* Fix RST formatting in docstring

Co-authored-by: Kaushik Kulkarni <15399010+kaushikcfd@users.noreply.github.com>

* Fix surface area computation in dt helper function

* Simplify surface area branches

* Update comments in dt utils

* Branch surface area computation based on actx broadcasting properties

* Test geometric factors using lazy actx

Co-authored-by: Kaushik Kulkarni <15399010+kaushikcfd@users.noreply.github.com>
Co-authored-by: Andreas Klöckner <inform@tiker.net>