Skip to content
Snippets Groups Projects

P2P Matrix Generator

Merged Alexandru Fikl requested to merge fikl2/sumpy:p2p-matrix into master
All threads resolved!

Adds a matrix generator for P2P similar to the LayerPotentialMatrixGenerator in qbx.py.

Still needs some work with:

  • Naming of the new classes.
  • inames?
Edited by Alexandru Fikl

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Andreas Klöckner
  • I'll think about the names some and get back to you.

  • Alexandru Fikl added 1 commit

    added 1 commit

    Compare with previous version

  • Alexandru Fikl resolved all discussions

    resolved all discussions

  • Alexandru Fikl marked the checklist item Naming of the new classes. as completed

    marked the checklist item Naming of the new classes. as completed

  • added 3 commits

    • 4813ebf4 - Bump kernel version, again
    • 969d51c3 - Improve names for P2P single-list base class
    • 3775ed9e - Fix string format brace escaping in generalized P2P

    Compare with previous version

  • Andreas Klöckner
  • Andreas Klöckner
  • Ready to go from my perspective. Let me know if you have any final things to do. If not, I'd go ahead and merge it.

  • Alexandru Fikl added 1 commit

    added 1 commit

    • dd952242 - add autoclass for new classes

    Compare with previous version

  • Fixed the other inames thing too. I kept thinking it was an error in how I was using the loopy, but turns out my Python is just bad. :(

    It all looks good to me now! All the tests pass locally, so once they pass on the CI it should be done.

  • Alexandru Fikl marked the checklist item inames? as completed

    marked the checklist item inames? as completed

  • Alexandru Fikl resolved all discussions

    resolved all discussions

  • Andreas Klöckner enabled an automatic merge when the pipeline for dd952242 succeeds

    enabled an automatic merge when the pipeline for dd952242 succeeds

  • Thanks again for working on this!

  • FYI: It's not normal for the tests to take forever: loopy#127 (closed). Should be back to ~10 min after that.

  • mentioned in commit c4a56148

  • Please register or sign in to reply
    Loading