Newer
Older
__copyright__ = "Copyright (C) 2018 Dong Zhuang"
__license__ = """
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
"""
from socket import error as socket_error, timeout as sock_timeout
from django.test import Client, RequestFactory, TestCase, override_settings
from docker.errors import APIError as DockerAPIError
from course.models import FlowSession
CODE_QUESTION_CONTAINER_PORT,
InvalidPingResponse,
PythonCodeQuestionWithHumanTextFeedback,
is_nuisance_failure,
request_run_with_retries,
)
from course.utils import CoursePageContext, FlowPageContext
MockAddMessageMixing,
SingleCoursePageTestMixin,
SingleCourseQuizPageTestMixin,
from tests.constants import MESSAGE_ANSWER_SAVED_TEXT, PAGE_ERRORS
from tests.test_sandbox import SingleCoursePageSandboxTestBaseMixin
from tests.utils import LocmemBackendTestsMixin, mail, mock
NO_CORRECTNESS_INFO_MSG = "No information on correctness of answer."
NOT_ALLOW_MULTIPLE_SUBMISSION_WARNING = (
"code question does not explicitly "
"allow multiple submission. Either add "
"access_rules/add_permssions/change_answer "
"or add 'single_submission: True' to confirm that you intend "
"for only a single submission to be allowed. "
"While you're at it, consider adding "
"access_rules/add_permssions/see_correctness."
)
MAX_AUTO_FEEDBACK_POINTS_VALICATION_ERROR_MSG_PATTERN = (
"'max_auto_feedback_points' is invalid: expecting "
"a value within [0, %(max_extra_credit_factor)s], "
"got %(invalid_value)s."
)
GRADE_CODE_FAILING_MSG = (
"The grading code failed. Sorry about that."
)
RUNCODE_WITH_RETRIES_PATH = "course.page.code.request_run_with_retries"
AUTO_FEEDBACK_POINTS_OUT_OF_RANGE_ERROR_MSG_PATTERN = (
"'correctness' is invalid: expecting "
"a value within [0, %s] or None, "
"got %s."
)
class SingleCourseQuizPageCodeQuestionTest(
SingleCourseQuizPageTestMixin, MockAddMessageMixing,
SubprocessRunpyContainerMixin, TestCase):
client = Client()
client.force_login(cls.student_participation.user)
cls.start_flow(client, cls.flow_id)
def test_code_page_correct(self):
page_id = "addition"
submit_answer_response, post_grade_response = (
self.default_submit_page_answer_by_page_id_and_test(page_id))
self.assertAddMessageCalledWith(MESSAGE_ANSWER_SAVED_TEXT)
def test_code_page_wrong(self):
page_id = "addition"
submit_answer_response, post_grade_response = (
self.default_submit_page_answer_by_page_id_and_test(
page_id, answer_data={"answer": "c = a - b\r"},
self.assertAddMessageCalledWith(MESSAGE_ANSWER_SAVED_TEXT)
def test_code_page_identical_to_reference(self):
page_id = "addition"
submit_answer_response, post_grade_response = (
self.default_submit_page_answer_by_page_id_and_test(
page_id, answer_data={"answer": "c = a + b\r"},
self.assertAddMessageCalledWith(MESSAGE_ANSWER_SAVED_TEXT)
self.assertResponseContextAnswerFeedbackContainsFeedback(
submit_answer_response,
("It looks like you submitted code "
"that is identical to the reference "
"solution. This is not allowed."))
def test_code_human_feedback_page_submit(self):
page_id = "pymult"
submit_answer_response, post_grade_response = (
self.default_submit_page_answer_by_page_id_and_test(page_id))
self.assertAddMessageCalledWith(MESSAGE_ANSWER_SAVED_TEXT)
def test_code_human_feedback_page_grade1(self):
page_id = "pymult"
submit_answer_response, post_grade_response = (
self.default_submit_page_answer_by_page_id_and_test(
page_id, answer_data={"answer": "c = b * a\r"},
self.assertResponseContextAnswerFeedbackContainsFeedback(
post_grade_response, "The human grader assigned 2/2 points.")
def test_code_human_feedback_page_grade2(self):
page_id = "pymult"
feedback_text = "This is the feedback from instructor."
submit_answer_response, post_grade_response = (
self.default_submit_page_answer_by_page_id_and_test(
page_id, answer_data={"answer": "c = a / b\r"},
grade_data_extra_kwargs={"feedback_text": feedback_text},
expected_grade=2))
self.assertResponseContextAnswerFeedbackContainsFeedback(
self.assertResponseContextAnswerFeedbackContainsFeedback(
submit_answer_response, "The autograder assigned 0/2 points.")
self.assertResponseContextAnswerFeedbackContainsFeedback(
post_grade_response, "The human grader assigned 2/2 points.")
self.assertResponseContextAnswerFeedbackContainsFeedback(
post_grade_response, "The human grader assigned 2/2 points.")
def test_code_human_feedback_page_grade3(self):
page_id = "py_simple_list"
submit_answer_response, post_grade_response = (
self.default_submit_page_answer_by_page_id_and_test(
page_id, answer_data={"answer": "b = [a + 1] * 50\r"},
# this is testing feedback.finish(0.3, feedback_msg)
# 2 * 0.3 = 0.6
self.assertResponseContextAnswerFeedbackContainsFeedback(
submit_answer_response, "The autograder assigned 0.90/3 points.")
self.assertResponseContextAnswerFeedbackContainsFeedback(
submit_answer_response, "The elements in b have wrong values")
def test_code_human_feedback_page_grade4(self):
page_id = "py_simple_list"
submit_answer_response, post_grade_response = (
self.default_submit_page_answer_by_page_id_and_test(page_id))
self.assertResponseContextAnswerFeedbackContainsFeedback(
self.assertResponseContextAnswerFeedbackContainsFeedback(
post_grade_response, "The human grader assigned 1/1 points.")
resp = self.submit_page_human_grading_by_page_id_and_test(
page_id, grade_data=grade_data, expected_grades=None)
self.assertFormErrorLoose(resp, None)
# not released
feedback_text = "This is the feedback from instructor."
grade_data = {
"feedback_text": feedback_text
}
resp = self.submit_page_human_grading_by_page_id_and_test(
page_id, grade_data=grade_data, expected_grades=None)
self.assertResponseContextAnswerFeedbackNotContainsFeedback(
resp, "The human grader assigned 1/1 points.")
self.assertResponseContextAnswerFeedbackNotContainsFeedback(
resp, feedback_text)
class CodeQuestionTest(SingleCoursePageSandboxTestBaseMixin,
SubprocessRunpyContainerMixin, LocmemBackendTestsMixin,
TestCase):
def test_data_files_missing_random_question_data_file(self):
file_name = "foo"
markdown = (
markdowns.CODE_MARKDWON_PATTERN_WITH_DATAFILES
% {"extra_data_file": "- %s" % file_name}
)
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "data file '%s' not found" % file_name)
def test_data_files_missing_random_question_data_file_bad_format(self):
markdown = markdowns.CODE_MARKDWON_WITH_DATAFILES_BAD_FORMAT
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "data file '%s' not found" % "['foo', 'bar']")
def test_not_multiple_submit_warning(self):
markdown = (
markdowns.CODE_MARKDWON_PATTERN_WITH_DATAFILES
% {"extra_data_file": ""}
)
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(
resp,
NOT_ALLOW_MULTIPLE_SUBMISSION_WARNING
)
def test_not_multiple_submit_warning2(self):
markdown = markdowns.CODE_MARKDWON_NOT_EXPLICITLY_NOT_ALLOW_MULTI_SUBMIT1
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(
resp,
NOT_ALLOW_MULTIPLE_SUBMISSION_WARNING
)
def test_not_multiple_submit_warning3(self):
markdown = markdowns.CODE_MARKDWON_NOT_EXPLICITLY_NOT_ALLOW_MULTI_SUBMIT2
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(
resp,
NOT_ALLOW_MULTIPLE_SUBMISSION_WARNING
)
def test_allow_multiple_submit(self):
markdown = markdowns.CODE_MARKDWON
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(resp, None)
def test_explicity_not_allow_multiple_submit(self):
markdown = (
markdowns.CODE_MARKDWON_PATTERN_EXPLICITLY_NOT_ALLOW_MULTI_SUBMIT
% {"extra_data_file": ""}
)
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(resp, None)
def test_question_without_test_code(self):
markdown = markdowns.CODE_MARKDWON_PATTERN_WITHOUT_TEST_CODE
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(resp, None)
resp = self.get_page_sandbox_submit_answer_response(
markdown,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, None)
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, NO_CORRECTNESS_INFO_MSG)
def test_question_without_correct_code(self):
markdown = markdowns.CODE_MARKDWON_PATTERN_WITHOUT_CORRECT_CODE
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(resp, None)
resp = self.get_page_sandbox_submit_answer_response(
markdown,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, 1)
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
def test_question_with_human_feedback_both_feedback_value_feedback_percentage_present(self): # noqa
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 3,
"human_feedback": "human_feedback_value: 2",
"extra_attribute": "human_feedback_percentage: 20"})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "'human_feedback_value' and "
"'human_feedback_percentage' are not "
"allowed to coexist")
def test_question_with_human_feedback_neither_feedback_value_feedback_percentage_present(self): # noqa
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 3,
"human_feedback": "",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "expecting either 'human_feedback_value' "
"or 'human_feedback_percentage', found neither.")
def test_question_with_human_feedback_used_feedback_value_warning(self):
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 3,
"human_feedback": "human_feedback_value: 2",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(
resp,
"Used deprecated 'human_feedback_value' attribute--"
"use 'human_feedback_percentage' instead."
)
def test_question_with_human_feedback_used_feedback_value_bad_value(self):
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 0,
"human_feedback": "human_feedback_value: 2",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "'human_feedback_value' attribute is not allowed "
"if value of question is 0, use "
"'human_feedback_percentage' instead")
def test_question_with_human_feedback_used_feedback_value_invalid(self):
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 2,
"human_feedback": "human_feedback_value: 3",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "human_feedback_value greater than overall "
"value of question")
def test_question_with_human_feedback_feedback_percentage_invalid(self):
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 2,
"human_feedback": "human_feedback_percentage: 120",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "the value of human_feedback_percentage "
"must be between 0 and 100")
def test_question_with_human_feedback_value_0_feedback_full_percentage(self):
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 0,
"human_feedback": "human_feedback_percentage: 100",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(resp, None)
def test_question_with_human_feedback_value_0_feedback_0_percentage(self):
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 0,
"human_feedback": "human_feedback_percentage: 0",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(resp, None)
def test_request_run_with_retries_raise_uncaught_error_in_sandbox(self):
autospec=True
) as mock_runpy:
expected_error_str = ("This is an error raised with "
"request_run_with_retries")
# correct_code_explanation and correct_code
expected_feedback = (
'<p>This is the <a href="http://example.com/1">explanation'
'</a>.</p>The following code is a valid answer: '
'<pre>\nc = 2 + 1\n</pre>')
mock_runpy.side_effect = RuntimeError(expected_error_str)
resp = self.get_page_sandbox_submit_answer_response(
markdowns.CODE_MARKDWON,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp,
None)
self.assertResponseContextContains(resp, "correct_answer",
expected_feedback)
# No email when in sandbox
self.assertEqual(len(mail.outbox), 0)
def test_request_run_with_retries_raise_uncaught_error_debugging(self):
autospec=True
) as mock_runpy:
expected_error_str = ("This is an error raised with "
"request_run_with_retries")
mock_runpy.side_effect = RuntimeError(expected_error_str)
with override_settings(DEBUG=True):
resp = self.get_page_sandbox_submit_answer_response(
markdowns.CODE_MARKDWON,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp,
None)
# No email when debugging
self.assertEqual(len(mail.outbox), 0)
def test_request_run_with_retries_raise_uncaught_error(self):
autospec=True
) as mock_runpy:
expected_error_str = ("This is an error raised with "
"request_run_with_retries")
mock_runpy.side_effect = RuntimeError(expected_error_str)
with mock.patch("course.page.PageContext") as mock_page_context:
mock_page_context.return_value.in_sandbox = False
mock_page_context.return_value.course = self.course
# This remove the warning caused by mocked commit_sha value
# "CacheKeyWarning: Cache key contains characters that
# will cause errors ..."
mock_page_context.return_value.commit_sha = b"1234"
resp = self.get_page_sandbox_submit_answer_response(
markdowns.CODE_MARKDWON,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp,
None)
self.assertEqual(len(mail.outbox), 1)
self.assertIn(expected_error_str, mail.outbox[0].body)
def test_send_email_failure_when_request_run_with_retries_raise_uncaught_error(self): # noqa
autospec=True
) as mock_runpy:
expected_error_str = ("This is an error raised with "
"request_run_with_retries")
mock_runpy.side_effect = RuntimeError(expected_error_str)
with mock.patch("course.page.PageContext") as mock_page_context:
mock_page_context.return_value.in_sandbox = False
mock_page_context.return_value.course = self.course
# This remove the warning caused by mocked commit_sha value
# "CacheKeyWarning: Cache key contains characters that
# will cause errors ..."
mock_page_context.return_value.commit_sha = b"1234"
with mock.patch("django.core.mail.message.EmailMessage.send") as mock_send: # noqa
mock_send.side_effect = RuntimeError("some email send error")
resp = self.get_page_sandbox_submit_answer_response(
markdowns.CODE_MARKDWON,
self.assertContains(resp, expected_error_str)
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp,
None)
self.assertEqual(len(mail.outbox), 0)
def assert_runpy_result_and_response(self, result_type, expected_msgs=None,
Andreas Klöckner
committed
not_expected_msgs=None,
correctness=0, mail_count=0, in_html=False,
with mock.patch(RUNCODE_WITH_RETRIES_PATH, autospec=True) as mock_runpy:
result = {"result": result_type}
result.update(extra_result)
mock_runpy.return_value = result
resp = self.get_page_sandbox_submit_answer_response(
markdowns.CODE_MARKDWON,
if isinstance(expected_msgs, str):
expected_msgs = [expected_msgs]
for msg in expected_msgs:
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, msg, html=in_html)
Andreas Klöckner
committed
if not_expected_msgs is not None:
if isinstance(not_expected_msgs, str):
Andreas Klöckner
committed
not_expected_msgs = [not_expected_msgs]
for msg in not_expected_msgs:
self.assertResponseContextAnswerFeedbackNotContainsFeedback(
resp, msg)
self.assertResponseContextAnswerFeedbackNotContainsFeedback(
resp, msg, html=True)
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp,
correctness)
self.assertEqual(len(mail.outbox), mail_count)
def test_request_run_with_retries_timed_out(self):
self.assert_runpy_result_and_response(
"timeout",
"Your code took too long to execute.")
def test_user_compile_error(self):
self.assert_runpy_result_and_response(
"user_compile_error",
"Your code failed to compile."
)
def test_user_error(self):
self.assert_runpy_result_and_response(
"user_error",
"Your code failed with an exception.")
def test_unknown_error(self):
with self.assertRaises(RuntimeError) as e:
self.assert_runpy_result_and_response(
"unknown_error", None)
self.assertIn("invalid run result: unknown_error", str(e.exception))
def test_traceback_in_feedback(self):
self.assert_runpy_result_and_response(
"user_error",
"some traceback",
traceback="some traceback"
)
def test_stdout_in_feedback(self):
self.assert_runpy_result_and_response(
"user_error",
"some stdout",
stdout="some stdout"
)
def test_stderr_in_feedback(self):
self.assert_runpy_result_and_response(
"user_error",
"some stderr",
stderr="some stderr"
)
def test_exechost_local(self):
self.assert_runpy_result_and_response(
"user_error",
Andreas Klöckner
committed
not_expected_msgs="Your code ran on",
exec_host="localhost"
)
def test_exechost_ip(self):
with mock.patch("socket.gethostbyaddr") as mock_get_host:
ip = "192.168.1.100"
resolved = "example.com"
mock_get_host.side_effect = lambda x: (resolved, [], [])
self.assert_runpy_result_and_response(
"user_error",
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
exec_host=ip
)
def test_exechost_ip_resolve_failure(self):
with mock.patch("socket.gethostbyaddr") as mock_get_host:
ip = "192.168.1.100"
mock_get_host.side_effect = socket_error
self.assert_runpy_result_and_response(
"user_error",
execpted_msgs="Your code ran on %s" % ip,
exec_host=ip
)
def test_figures(self):
bmp_b64 = ("data:image/bmp;base64,Qk1GAAAAAAAAAD4AAAAoAAAAAgAAAAIA"
"AAABAAEAAAAAAAgAAADEDgAAxA4AAAAAAAAAAAAAAAAAAP///wDAAAA"
"AwAAAAA==")
jpeg_b64 = ("data:image/jpeg;base64,/9j/4AAQSkZJRgABAQEAYABgAAD/4QBa"
"RXhpZgAATU0AKgAAAAgABQMBAAUAAAABAAAASgMDAAEAAAABAAAAAFE"
"QAAEAAAABAQAAAFERAAQAAAABAAAOwlESAAQAAAABAAAOwgAAAAAAAY"
"agAACxj//bAEMAAgEBAgEBAgICAgICAgIDBQMDAwMDBgQEAwUHBgcHB"
"wYHBwgJCwkICAoIBwcKDQoKCwwMDAwHCQ4PDQwOCwwMDP/bAEMBAgIC"
"AwMDBgMDBgwIBwgMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw"
"MDAwMDAwMDAwMDAwMDAwMDAwMDP/AABEIAAIAAgMBIgACEQEDEQH/xA"
"AfAAABBQEBAQEBAQAAAAAAAAAAAQIDBAUGBwgJCgv/xAC1EAACAQMDA"
"gQDBQUEBAAAAX0BAgMABBEFEiExQQYTUWEHInEUMoGRoQgjQrHBFVLR8"
"CQzYnKCCQoWFxgZGiUmJygpKjQ1Njc4OTpDREVGR0hJSlNUVVZXWFlaY"
"2RlZmdoaWpzdHV2d3h5eoOEhYaHiImKkpOUlZaXmJmaoqOkpaanqKmq"
"srO0tba3uLm6wsPExcbHyMnK0tPU1dbX2Nna4eLj5OXm5+jp6vHy8/T"
"19vf4+fr/xAAfAQADAQEBAQEBAQEBAAAAAAAAAQIDBAUGBwgJCgv/xA"
"C1EQACAQIEBAMEBwUEBAABAncAAQIDEQQFITEGEkFRB2FxEyIygQgUQp"
"GhscEJIzNS8BVictEKFiQ04SXxFxgZGiYnKCkqNTY3ODk6Q0RFRkdIS"
"UpTVFVWV1hZWmNkZWZnaGlqc3R1dnd4eXqCg4SFhoeIiYqSk5SVlpeY"
"mZqio6Slpqeoqaqys7S1tre4ubrCw8TFxsfIycrS09TV1tfY2dri4+T"
"l5ufo6ery8/T19vf4+fr/2gAMAwEAAhEDEQA/AP38ooooA//Z")
png_b64 = (
"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAIAAAACAQMAAAB"
"IeJ9nAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAGUExURQAAAP///"
"6XZn90AAAAJcEhZcwAADsIAAA7CARUoSoAAAAAMSURBVBjTYzjAcAAAAwQBgXn"
"6PNcAAAAASUVORK5CYII=")
self.assert_runpy_result_and_response(
"user_error",
expected_msgs=[png_b64, jpeg_b64, "Figure1", "Figure 1",
"Figure3", "Figure 3", ],
Andreas Klöckner
committed
not_expected_msgs=[bmp_b64, "Figure2", "Figure 2"],
figures=[
[1, "image/png", png_b64],
[2, "image/bmp", bmp_b64],
[3, "image/jpeg", jpeg_b64]
]
)
def test_html_in_feedback(self):
html = "<ul><li>some html</li></ul>"
self.assert_runpy_result_and_response(
"user_error",
html,
html=[html]
)
js = "<script>console.log('good')</script>"
html_with_js = html + js
self.assert_runpy_result_and_response(
"user_error",
expected_msgs=html,
Andreas Klöckner
committed
not_expected_msgs=js, # js is sanitized
html=[html_with_js]
)
def test_html_audio(self):
b64_data = "T2dnUwACAAAAAAAAAAA+HAAAAAAAAGyawCEBQGZpc2h"
audio_valid1 = (
'<audio controls><source src="data:audio/wav;base64,'
'%s" type="audio/wav">'
'</audio>' % b64_data)
audio_valid2 = (
'<audio><source src="data:audio/wav;base64,'
'%s" type="audio/wav">'
'</audio>' % b64_data)
'<audio control><source src="data:audio/wav;base64,'
'%s" type="audio/wav">'
'</audio>' % b64_data)
'<audio controls><source href="data:audio/wav;base64,'
'%s" type="audio/wav">'
'</audio>' % b64_data)
'<audio controls><source src="data:audio/ogg;base64,'
'%s" type="audio/ogg">'
'</audio>' % b64_data)
audio_invalid4 = (
'<audio controls><source src="hosse.wav" type="audio/wav">'
'</audio>')
html = [audio_valid1, audio_valid2, audio_invalid1, audio_invalid2,
audio_invalid3, audio_invalid4]
self.assert_runpy_result_and_response(
"user_error",
expected_msgs=[audio_valid1, audio_valid2],
Andreas Klöckner
committed
not_expected_msgs=[audio_invalid1, audio_invalid2, audio_invalid3,
audio_invalid4],
html=html,
in_html=True
)
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
# {{{ Failed tests
# def test_html_img(self):
# b64_data = ("iVBORw0KGgoAAAANSUhEUgAAAAIAAAACAQMAAAB"
# "IeJ9nAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAGUExURQAAAP///"
# "6XZn90AAAAJcEhZcwAADsIAAA7CARUoSoAAAAAMSURBVBjTYzjAcAAAAwQBgXn"
# "6PNcAAAAASUVORK5CYII=")
#
# img_valid = (
# '<img src="data:image/png;base64,%s" alt="test img" '
# 'title="test image">' % b64_data)
#
# img_invalid1 = (
# '<img src="data:image/png;base64,%s" '
# 'alt="test img" '
# 'width="126" '
# 'height="44">' % b64_data)
#
# img_invalid2 = (
# '<img href="data:image/png;base64,%s" '
# 'alt="test img" title="test image">' % b64_data)
#
# img_invalid3 = (
# '<img src="data:image/bmp;base64,%s" '
# 'alt="test img" title="test image">' % b64_data)
#
# html = [img_valid, img_invalid1, img_invalid2, img_invalid3]
#
# self.assert_runpy_result_and_response(
# "user_error",
# expected_msgs=[img_valid],
# not_expected_msgs=[img_invalid1, img_invalid2, img_invalid3],
# html=html,
# in_html=True,
# )
#
# evil_b64_data = ("iVBORw0KGgoAAAANSUhEUgAAAAIAAAACAQMAAAB=")
# evil_data_html_strings = [
# '<a src="data:,Hello%2C%20Evil%20World!"></a>',
# '<a href="data:,Hello%2C%20Evil%20World!"></a>',
# '<a src="data:text/html;base64,%s"</a>' % evil_b64_data,
# '<a src="data:text/html;base64,%s"</a>' % evil_b64_data,
# '<img src="https://Evil.com">',
#
# '<script src="data:text/html,<script>alert("Evil");"</script>',
# '<script href="data:text/html,<script>alert("Evil");"</script>',
# '<script src="data:text/html;base64,%s"</script>' % evil_b64_data,
# '<script href="data:text/html;base64,%s"</script>' % evil_b64_data,
#
# '<style src="data:,Evilcss">',
# '<style src="data:image/png;base64,%s">' % evil_b64_data,
# '<style href="data:image/png;base64,%s">' % evil_b64_data,
# ]
# def test_html_from_code_sanitization(self):
# from course.page.code import sanitize_from_code_html
# for evhtml in self.evil_data_html_strings:
# print("------------------")
# print(evhtml)
# sanitized = sanitize_from_code_html(evhtml)
# print(sanitized)
#
# assert "Evil" not in sanitized
# def test_html_with_data_protocol_for_other_tags_sanitized(self):
# # Fixed https://github.com/inducer/relate/issues/435
# # Ref: https://github.com/mozilla/bleach/issues/348
#
# self.assert_runpy_result_and_response(
# "user_error",
# not_expected_msgs=self.evil_data_html_strings + ["Evil"],
# html=self.evil_data_html_strings,
# in_html=True,
# )
# }}}
def test_html_non_text_bleached_in_feedback(self):
self.assert_runpy_result_and_response(
"user_error",
"(Non-string in 'HTML' output filtered out)",
html=b"not string"
)
# {{{ https://github.com/inducer/relate/pull/448
Dong Zhuang
committed
def test_feedback_points_close_to_1(self):
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": 1.000000000002,
"min_points": 0
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
resp = self.get_page_sandbox_submit_answer_response(
markdown,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, 1)
def test_feedback_code_exceed_1(self):
feedback_points = 1.1
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": feedback_points,
"min_points": 0
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
resp = self.get_page_sandbox_submit_answer_response(
markdown,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, 1.1)
expected_feedback = "Your answer is correct and earned bonus points."
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, expected_feedback)
def test_feedback_code_positive_close_to_0(self):
# https://github.com/inducer/relate/pull/448#issuecomment-363655132
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": 1,
"min_points": 0.00000000001
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
# Post a wrong answer
resp = self.get_page_sandbox_submit_answer_response(
markdown,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, 0)
def test_feedback_code_negative_close_to_0(self):
# https://github.com/inducer/relate/pull/448#issuecomment-363655132
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": 1,
"min_points": -0.00000000001
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
# Post a wrong answer
resp = self.get_page_sandbox_submit_answer_response(
markdown,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, 0)
def test_feedback_code_error_close_below_max_auto_feedback_points(self):
feedback_points = MAX_EXTRA_CREDIT_FACTOR - 1e-6
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": feedback_points,
"min_points": 0
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
resp = self.get_page_sandbox_submit_answer_response(
markdown,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(
resp, MAX_EXTRA_CREDIT_FACTOR)
def test_feedback_code_error_close_above_max_auto_feedback_points(self):
feedback_points = MAX_EXTRA_CREDIT_FACTOR + 1e-6
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": feedback_points,
"min_points": 0
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
resp = self.get_page_sandbox_submit_answer_response(
markdown,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(
resp, MAX_EXTRA_CREDIT_FACTOR)
def test_feedback_code_error_negative_feedback_points(self):
invalid_feedback_points = -0.1
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": 1,
"min_points": invalid_feedback_points
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
# Post a wrong answer
resp = self.get_page_sandbox_submit_answer_response(
markdown,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, None)
error_msg = (AUTO_FEEDBACK_POINTS_OUT_OF_RANGE_ERROR_MSG_PATTERN
% (MAX_EXTRA_CREDIT_FACTOR, invalid_feedback_points))
self.assertResponseContextAnswerFeedbackNotContainsFeedback(
resp, error_msg)
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, GRADE_CODE_FAILING_MSG)
def test_feedback_code_error_exceed_max_extra_credit_factor(self):
invalid_feedback_points = 10.1
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": invalid_feedback_points,
"min_points": 0
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
resp = self.get_page_sandbox_submit_answer_response(
markdown,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, None)
error_msg = (AUTO_FEEDBACK_POINTS_OUT_OF_RANGE_ERROR_MSG_PATTERN
% (MAX_EXTRA_CREDIT_FACTOR, invalid_feedback_points))
self.assertResponseContextAnswerFeedbackNotContainsFeedback(
resp, error_msg)
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, GRADE_CODE_FAILING_MSG)
def test_feedback_code_error_exceed_max_extra_credit_factor_email(self):
invalid_feedback_points = 10.1
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": invalid_feedback_points,
"min_points": 0
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
with mock.patch("course.page.PageContext") as mock_page_context:
mock_page_context.return_value.in_sandbox = False
mock_page_context.return_value.course = self.course
# This remove the warning caused by mocked commit_sha value
# "CacheKeyWarning: Cache key contains characters that
# will cause errors ..."
mock_page_context.return_value.commit_sha = b"1234"
resp = self.get_page_sandbox_submit_answer_response(
markdown,
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, None)
error_msg = (AUTO_FEEDBACK_POINTS_OUT_OF_RANGE_ERROR_MSG_PATTERN
% (MAX_EXTRA_CREDIT_FACTOR, invalid_feedback_points))
self.assertResponseContextAnswerFeedbackNotContainsFeedback(
resp, error_msg)
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, GRADE_CODE_FAILING_MSG)
self.assertEqual(len(mail.outbox), 1)
self.assertIn(error_msg, mail.outbox[0].body)