Newer
Older
from __future__ import division
__copyright__ = "Copyright (C) 2018 Dong Zhuang"
__license__ = """
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
"""
from django.test import TestCase, override_settings, RequestFactory
from docker.errors import APIError as DockerAPIError
from socket import error as socket_error, timeout as sock_timeout
import errno
from course.models import FlowSession
from course.page.code import (
RUNPY_PORT, request_python_run_with_retries, InvalidPingResponse,
is_nuisance_failure, PythonCodeQuestionWithHumanTextFeedback)
from course.utils import FlowPageContext, CoursePageContext
from course.constants import MAX_EXTRA_CREDIT_FACTOR
from tests.test_pages import QUIZ_FLOW_ID
from tests.test_pages.test_generic import MESSAGE_ANSWER_SAVED_TEXT
SubprocessRunpyContainerMixin, SingleCoursePageTestMixin,
FallBackStorageMessageTestMixin)
from tests.test_sandbox import (
SingleCoursePageSandboxTestBaseMixin, PAGE_ERRORS
)
from tests.utils import LocmemBackendTestsMixin, mock, mail
from . import markdowns
NO_CORRECTNESS_INFO_MSG = "No information on correctness of answer."
NOT_ALLOW_MULTIPLE_SUBMISSION_WARNING = (
"code question does not explicitly "
"allow multiple submission. Either add "
"access_rules/add_permssions/change_answer "
"or add 'single_submission: True' to confirm that you intend "
"for only a single submission to be allowed. "
"While you're at it, consider adding "
"access_rules/add_permssions/see_correctness."
)
MAX_AUTO_FEEDBACK_POINTS_VALICATION_ERROR_MSG_PATTERN = ( # noqa
"'max_auto_feedback_points' is invalid: expecting "
"a value within [0, %(max_extra_credit_factor)s], "
"got %(invalid_value)s."
)
GRADE_CODE_FAILING_MSG = (
"The grading code failed. Sorry about that."
)
RUNPY_WITH_RETRIES_PATH = "course.page.code.request_python_run_with_retries"
AUTO_FEEDBACK_POINTS_OUT_OF_RANGE_ERROR_MSG_PATTERN = (
"'correctness' is invalid: expecting "
"a value within [0, %s] or None, "
"got %s."
)
class SingleCourseQuizPageCodeQuestionTest(
SingleCoursePageTestMixin, FallBackStorageMessageTestMixin,
SubprocessRunpyContainerMixin, TestCase):
@classmethod
def setUpTestData(cls): # noqa
super(SingleCourseQuizPageCodeQuestionTest, cls).setUpTestData()
cls.c.force_login(cls.student_participation.user)
cls.start_flow(cls.flow_id)
super(SingleCourseQuizPageCodeQuestionTest, self).setUp()
# This is needed to ensure student is logged in
self.c.force_login(self.student_participation.user)
def test_code_page_correct(self):
page_id = "addition"
resp = self.post_answer_by_page_id(
page_id, {"answer": ['c = b + a\r']})
self.assertEqual(resp.status_code, 200)
self.assertResponseMessagesContains(resp, MESSAGE_ANSWER_SAVED_TEXT)
self.assertEqual(self.end_flow().status_code, 200)
self.assertSessionScoreEqual(1)
def test_code_page_wrong(self):
page_id = "addition"
resp = self.post_answer_by_page_id(
page_id, {"answer": ['c = a - b\r']})
self.assertEqual(resp.status_code, 200)
self.assertResponseMessagesContains(resp, MESSAGE_ANSWER_SAVED_TEXT)
self.assertEqual(self.end_flow().status_code, 200)
self.assertSessionScoreEqual(0)
def test_code_page_identical_to_reference(self):
page_id = "addition"
resp = self.post_answer_by_page_id(
page_id, {"answer": ['c = a + b\r']})
self.assertEqual(resp.status_code, 200)
self.assertResponseMessagesContains(resp, MESSAGE_ANSWER_SAVED_TEXT)
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp,
("It looks like you submitted code "
"that is identical to the reference "
"solution. This is not allowed."))
self.assertEqual(self.end_flow().status_code, 200)
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
self.assertSessionScoreEqual(1)
def test_download_code_submissions_no_answer(self):
group_page_id = "quiz_tail/addition"
self.end_flow()
# no answer
with self.temporarily_switch_to_user(self.instructor_participation.user):
resp = self.post_download_all_submissions_by_group_page_id(
group_page_id=group_page_id, flow_id=self.flow_id)
self.assertEqual(resp.status_code, 200)
prefix, zip_file = resp["Content-Disposition"].split('=')
self.assertEqual(prefix, "attachment; filename")
self.assertEqual(resp.get('Content-Type'), "application/zip")
buf = six.BytesIO(resp.content)
with zipfile.ZipFile(buf, 'r') as zf:
self.assertIsNone(zf.testzip())
self.assertEqual(
len([f for f in zf.filelist if f.filename.endswith('.py')]), 0)
for f in zf.filelist:
self.assertGreater(f.file_size, 0)
def test_download_code_submissions_has_answer(self):
group_page_id = "quiz_tail/addition"
# create an answer
page_id = "addition"
self.post_answer_by_page_id(
page_id, {"answer": ['c = a - b\r']})
self.end_flow()
with self.temporarily_switch_to_user(self.instructor_participation.user):
resp = self.post_download_all_submissions_by_group_page_id(
group_page_id=group_page_id, flow_id=self.flow_id)
self.assertEqual(resp.status_code, 200)
prefix, zip_file = resp["Content-Disposition"].split('=')
self.assertEqual(prefix, "attachment; filename")
self.assertEqual(resp.get('Content-Type'), "application/zip")
buf = six.BytesIO(resp.content)
with zipfile.ZipFile(buf, 'r') as zf:
self.assertIsNone(zf.testzip())
# todo: make more assertions in terms of file content
self.assertEqual(
len([f for f in zf.filelist if f.filename.endswith('.py')]), 1)
for f in zf.filelist:
self.assertGreater(f.file_size, 0)
def test_code_page_analytics_no_answer(self):
# analytics with no answer
page_id = "addition"
self.end_flow()
with self.temporarily_switch_to_user(self.instructor_participation.user):
resp = self.get_flow_page_analytics(
flow_id=self.flow_id, group_id="quiz_tail",
page_id=page_id)
self.assertEqual(resp.status_code, 200)
def test_code_page_analytics_has_answer(self):
# create an answer
page_id = "addition"
self.post_answer_by_page_id(
page_id, {"answer": ['c = a - b\r']})
self.end_flow()
# todo: make more assertions in terms of content
with self.temporarily_switch_to_user(self.instructor_participation.user):
resp = self.get_flow_page_analytics(
flow_id=self.flow_id, group_id="quiz_tail",
page_id=page_id)
self.assertEqual(resp.status_code, 200)
def test_code_human_feedback_page_submit(self):
page_id = "pymult"
resp = self.post_answer_by_page_id(
page_id, {"answer": ['c = a * b\r']})
self.assertEqual(resp.status_code, 200)
self.assertResponseMessagesContains(resp, MESSAGE_ANSWER_SAVED_TEXT)
self.assertEqual(self.end_flow().status_code, 200)
self.assertSessionScoreEqual(None)
def test_code_human_feedback_page_grade1(self):
page_id = "pymult"
resp = self.post_answer_by_page_id(
page_id, {"answer": ['c = b * a\r']})
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, "'c' looks good")
self.assertEqual(self.end_flow().status_code, 200)
grade_data = {
"grade_percent": ["100"],
"released": ["on"]
}
resp = self.post_grade_by_page_id(page_id, grade_data)
self.assertTrue(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, "The human grader assigned 2/2 points.")
# since the test_code didn't do a feedback.set_points() after
# check_scalar()
self.assertSessionScoreEqual(None)
def test_code_human_feedback_page_grade2(self):
page_id = "pymult"
resp = self.post_answer_by_page_id(
page_id, {"answer": ['c = a / b\r']})
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, "'c' is inaccurate")
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, "The autograder assigned 0/2 points.")
self.assertEqual(self.end_flow().status_code, 200)
feedback_text = "This is the feedback from instructor."
grade_data = {
"grade_percent": ["100"],
"released": ["on"],
"feedback_text": feedback_text
}
resp = self.post_grade_by_page_id(page_id, grade_data)
self.assertTrue(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, "The human grader assigned 2/2 points.")
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, feedback_text)
self.assertSessionScoreEqual(2)
def test_code_human_feedback_page_grade3(self):
page_id = "py_simple_list"
resp = self.post_answer_by_page_id(
page_id, {"answer": ['b = [a + 1] * 50\r']})
# this is testing feedback.finish(0.3, feedback_msg)
# 2 * 0.3 = 0.6
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, "The autograder assigned 0.90/3 points.")
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, "The elements in b have wrong values")
self.assertEqual(self.end_flow().status_code, 200)
# The page is not graded before human grading.
self.assertSessionScoreEqual(None)
def test_code_human_feedback_page_grade4(self):
page_id = "py_simple_list"
resp = self.post_answer_by_page_id(
page_id, {"answer": ['b = [a] * 50\r']})
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, "b looks good")
self.assertEqual(self.end_flow().status_code, 200)
grade_data = {
"grade_percent": ["100"],
"released": ["on"]
}
resp = self.post_grade_by_page_id(page_id, grade_data)
self.assertTrue(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, "The human grader assigned 1/1 points.")
self.assertSessionScoreEqual(4)
grade_data = {
"released": ["on"]
}
resp = self.post_grade_by_page_id(page_id, grade_data)
self.assertTrue(resp.status_code, 200)
self.assertFormErrorLoose(resp, None)
self.assertSessionScoreEqual(None)
# not released
feedback_text = "This is the feedback from instructor."
grade_data = {
"grade_percent": ["100"],
"feedback_text": feedback_text
}
resp = self.post_grade_by_page_id(page_id, grade_data)
self.assertTrue(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackNotContainsFeedback(
resp, "The human grader assigned 1/1 points.")
self.assertResponseContextAnswerFeedbackNotContainsFeedback(
resp, feedback_text)
self.assertSessionScoreEqual(None)
class CodeQuestionTest(SingleCoursePageSandboxTestBaseMixin,
SubprocessRunpyContainerMixin, LocmemBackendTestsMixin,
TestCase):
def test_data_files_missing_random_question_data_file(self):
file_name = "foo"
markdown = (
markdowns.CODE_MARKDWON_PATTERN_WITH_DATAFILES
% {"extra_data_file": "- %s" % file_name}
)
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "data file '%s' not found" % file_name)
def test_data_files_missing_random_question_data_file_bad_format(self):
markdown = markdowns.CODE_MARKDWON_WITH_DATAFILES_BAD_FORMAT
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "data file '%s' not found" % "['foo', 'bar']")
def test_not_multiple_submit_warning(self):
markdown = (
markdowns.CODE_MARKDWON_PATTERN_WITH_DATAFILES
% {"extra_data_file": ""}
)
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(
resp,
NOT_ALLOW_MULTIPLE_SUBMISSION_WARNING
)
def test_not_multiple_submit_warning2(self):
markdown = markdowns.CODE_MARKDWON_NOT_EXPLICITLY_NOT_ALLOW_MULTI_SUBMIT1
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(
resp,
NOT_ALLOW_MULTIPLE_SUBMISSION_WARNING
)
def test_not_multiple_submit_warning3(self):
markdown = markdowns.CODE_MARKDWON_NOT_EXPLICITLY_NOT_ALLOW_MULTI_SUBMIT2
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(
resp,
NOT_ALLOW_MULTIPLE_SUBMISSION_WARNING
)
def test_allow_multiple_submit(self):
markdown = markdowns.CODE_MARKDWON
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(resp, None)
def test_explicity_not_allow_multiple_submit(self):
markdown = (
markdowns.CODE_MARKDWON_PATTERN_EXPLICITLY_NOT_ALLOW_MULTI_SUBMIT
% {"extra_data_file": ""}
)
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(resp, None)
def test_question_without_test_code(self):
markdown = markdowns.CODE_MARKDWON_PATTERN_WITHOUT_TEST_CODE
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(resp, None)
resp = self.get_page_sandbox_submit_answer_response(
markdown,
answer_data={"answer": ['c = b + a\r']})
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, None)
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, NO_CORRECTNESS_INFO_MSG)
def test_question_without_correct_code(self):
markdown = markdowns.CODE_MARKDWON_PATTERN_WITHOUT_CORRECT_CODE
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(resp, None)
resp = self.get_page_sandbox_submit_answer_response(
markdown,
answer_data={"answer": ['c = b + a\r']})
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, 1)
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
def test_question_with_human_feedback_both_feedback_value_feedback_percentage_present(self): # noqa
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 3,
"human_feedback": "human_feedback_value: 2",
"extra_attribute": "human_feedback_percentage: 20"})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "'human_feedback_value' and "
"'human_feedback_percentage' are not "
"allowed to coexist")
def test_question_with_human_feedback_neither_feedback_value_feedback_percentage_present(self): # noqa
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 3,
"human_feedback": "",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "expecting either 'human_feedback_value' "
"or 'human_feedback_percentage', found neither.")
def test_question_with_human_feedback_used_feedback_value_warning(self):
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 3,
"human_feedback": "human_feedback_value: 2",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(
resp,
"Used deprecated 'human_feedback_value' attribute--"
"use 'human_feedback_percentage' instead."
)
def test_question_with_human_feedback_used_feedback_value_bad_value(self):
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 0,
"human_feedback": "human_feedback_value: 2",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "'human_feedback_value' attribute is not allowed "
"if value of question is 0, use "
"'human_feedback_percentage' instead")
def test_question_with_human_feedback_used_feedback_value_invalid(self):
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 2,
"human_feedback": "human_feedback_value: 3",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "human_feedback_value greater than overall "
"value of question")
def test_question_with_human_feedback_feedback_percentage_invalid(self):
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 2,
"human_feedback": "human_feedback_percentage: 120",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxNotHasValidPage(resp)
self.assertResponseContextContains(
resp, PAGE_ERRORS, "the value of human_feedback_percentage "
"must be between 0 and 100")
def test_question_with_human_feedback_value_0_feedback_full_percentage(self):
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 0,
"human_feedback": "human_feedback_percentage: 100",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(resp, None)
def test_question_with_human_feedback_value_0_feedback_0_percentage(self):
markdown = (markdowns.CODE_WITH_HUMAN_FEEDBACK_MARKDWON_PATTERN
% {"value": 0,
"human_feedback": "human_feedback_percentage: 0",
"extra_attribute": ""})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
self.assertSandboxWarningTextContain(resp, None)
def test_request_python_run_with_retries_raise_uncaught_error_in_sandbox(self):
with mock.patch(
RUNPY_WITH_RETRIES_PATH,
autospec=True
) as mock_runpy:
expected_error_str = ("This is an error raised with "
"request_python_run_with_retries")
# correct_code_explanation and correct_code
expected_feedback = (
'<p>This is the <a href="http://example.com/1">explanation'
'</a>.</p>The following code is a valid answer: '
'<pre>\nc = 2 + 1\n</pre>')
mock_runpy.side_effect = RuntimeError(expected_error_str)
resp = self.get_page_sandbox_submit_answer_response(
markdowns.CODE_MARKDWON,
answer_data={"answer": ['c = 1 + 2\r']})
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp,
None)
self.assertResponseContextContains(resp, "correct_answer",
expected_feedback)
# No email when in sandbox
self.assertEqual(len(mail.outbox), 0)
def test_request_python_run_with_retries_raise_uncaught_error_debugging(self):
with mock.patch(
RUNPY_WITH_RETRIES_PATH,
autospec=True
) as mock_runpy:
expected_error_str = ("This is an error raised with "
"request_python_run_with_retries")
mock_runpy.side_effect = RuntimeError(expected_error_str)
with override_settings(DEBUG=True):
resp = self.get_page_sandbox_submit_answer_response(
markdowns.CODE_MARKDWON,
answer_data={"answer": ['c = 1 + 2\r']})
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp,
None)
# No email when debugging
self.assertEqual(len(mail.outbox), 0)
def test_request_python_run_with_retries_raise_uncaught_error(self):
with mock.patch(
RUNPY_WITH_RETRIES_PATH,
autospec=True
) as mock_runpy:
expected_error_str = ("This is an error raised with "
"request_python_run_with_retries")
mock_runpy.side_effect = RuntimeError(expected_error_str)
with mock.patch("course.page.PageContext") as mock_page_context:
mock_page_context.return_value.in_sandbox = False
# This remove the warning caused by mocked commit_sha value
# "CacheKeyWarning: Cache key contains characters that
# will cause errors ..."
mock_page_context.return_value.commit_sha = b"1234"
resp = self.get_page_sandbox_submit_answer_response(
markdowns.CODE_MARKDWON,
answer_data={"answer": ['c = 1 + 2\r']})
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp,
None)
self.assertEqual(len(mail.outbox), 1)
self.assertIn(expected_error_str, mail.outbox[0].body)
def test_send_email_failure_when_request_python_run_with_retries_raise_uncaught_error(self): # noqa
with mock.patch(
RUNPY_WITH_RETRIES_PATH,
autospec=True
) as mock_runpy:
expected_error_str = ("This is an error raised with "
"request_python_run_with_retries")
mock_runpy.side_effect = RuntimeError(expected_error_str)
with mock.patch("course.page.PageContext") as mock_page_context:
mock_page_context.return_value.in_sandbox = False
# This remove the warning caused by mocked commit_sha value
# "CacheKeyWarning: Cache key contains characters that
# will cause errors ..."
mock_page_context.return_value.commit_sha = b"1234"
with mock.patch("django.core.mail.message.EmailMessage.send") as mock_send: # noqa
mock_send.side_effect = RuntimeError("some email send error")
resp = self.get_page_sandbox_submit_answer_response(
markdowns.CODE_MARKDWON,
answer_data={"answer": ['c = 1 + 2\r']})
self.assertContains(resp, expected_error_str)
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp,
None)
self.assertEqual(len(mail.outbox), 0)
def assert_runpy_result_and_response(self, result_type, expected_msgs=None,
Andreas Klöckner
committed
not_expected_msgs=None,
correctness=0, mail_count=0, in_html=False,
**extra_result):
with mock.patch(RUNPY_WITH_RETRIES_PATH, autospec=True) as mock_runpy:
result = {"result": result_type}
result.update(extra_result)
mock_runpy.return_value = result
resp = self.get_page_sandbox_submit_answer_response(
markdowns.CODE_MARKDWON,
answer_data={"answer": ['c = 1 + 2\r']})
if expected_msgs is not None:
if isinstance(expected_msgs, six.text_type):
expected_msgs = [expected_msgs]
for msg in expected_msgs:
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, msg, html=in_html)
Andreas Klöckner
committed
if not_expected_msgs is not None:
if isinstance(not_expected_msgs, six.text_type):
not_expected_msgs = [not_expected_msgs]
for msg in not_expected_msgs:
self.assertResponseContextAnswerFeedbackNotContainsFeedback(
resp, msg, html=in_html)
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp,
correctness)
self.assertEqual(len(mail.outbox), mail_count)
def test_request_python_run_with_retries_timed_out(self):
self.assert_runpy_result_and_response(
"timeout",
"Your code took too long to execute.")
def test_user_compile_error(self):
self.assert_runpy_result_and_response(
"user_compile_error",
"Your code failed to compile."
)
def test_user_error(self):
self.assert_runpy_result_and_response(
"user_error",
"Your code failed with an exception.")
def test_unknown_error(self):
with self.assertRaises(RuntimeError) as e:
self.assert_runpy_result_and_response(
"unknown_error", None)
self.assertIn("invalid runpy result: unknown_error", str(e.exception))
def test_traceback_in_feedback(self):
self.assert_runpy_result_and_response(
"user_error",
"some traceback",
traceback="some traceback"
)
def test_stdout_in_feedback(self):
self.assert_runpy_result_and_response(
"user_error",
"some stdout",
stdout="some stdout"
)
def test_stderr_in_feedback(self):
self.assert_runpy_result_and_response(
"user_error",
"some stderr",
stderr="some stderr"
)
def test_exechost_local(self):
self.assert_runpy_result_and_response(
"user_error",
Andreas Klöckner
committed
not_expected_msgs="Your code ran on",
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
exec_host="localhost"
)
def test_exechost_ip(self):
with mock.patch("socket.gethostbyaddr") as mock_get_host:
ip = "192.168.1.100"
resovled = "example.com"
mock_get_host.side_effect = lambda x: (resovled, [], [])
self.assert_runpy_result_and_response(
"user_error",
execpted_msgs="Your code ran on %s" % resovled,
exec_host=ip
)
def test_exechost_ip_resolve_failure(self):
with mock.patch("socket.gethostbyaddr") as mock_get_host:
ip = "192.168.1.100"
mock_get_host.side_effect = socket_error
self.assert_runpy_result_and_response(
"user_error",
execpted_msgs="Your code ran on %s" % ip,
exec_host=ip
)
def test_figures(self):
bmp_b64 = ("data:image/bmp;base64,Qk1GAAAAAAAAAD4AAAAoAAAAAgAAAAIA"
"AAABAAEAAAAAAAgAAADEDgAAxA4AAAAAAAAAAAAAAAAAAP///wDAAAA"
"AwAAAAA==")
jpeg_b64 = ("data:image/jpeg;base64,/9j/4AAQSkZJRgABAQEAYABgAAD/4QBa"
"RXhpZgAATU0AKgAAAAgABQMBAAUAAAABAAAASgMDAAEAAAABAAAAAFE"
"QAAEAAAABAQAAAFERAAQAAAABAAAOwlESAAQAAAABAAAOwgAAAAAAAY"
"agAACxj//bAEMAAgEBAgEBAgICAgICAgIDBQMDAwMDBgQEAwUHBgcHB"
"wYHBwgJCwkICAoIBwcKDQoKCwwMDAwHCQ4PDQwOCwwMDP/bAEMBAgIC"
"AwMDBgMDBgwIBwgMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw"
"MDAwMDAwMDAwMDAwMDAwMDAwMDP/AABEIAAIAAgMBIgACEQEDEQH/xA"
"AfAAABBQEBAQEBAQAAAAAAAAAAAQIDBAUGBwgJCgv/xAC1EAACAQMDA"
"gQDBQUEBAAAAX0BAgMABBEFEiExQQYTUWEHInEUMoGRoQgjQrHBFVLR8"
"CQzYnKCCQoWFxgZGiUmJygpKjQ1Njc4OTpDREVGR0hJSlNUVVZXWFlaY"
"2RlZmdoaWpzdHV2d3h5eoOEhYaHiImKkpOUlZaXmJmaoqOkpaanqKmq"
"srO0tba3uLm6wsPExcbHyMnK0tPU1dbX2Nna4eLj5OXm5+jp6vHy8/T"
"19vf4+fr/xAAfAQADAQEBAQEBAQEBAAAAAAAAAQIDBAUGBwgJCgv/xA"
"C1EQACAQIEBAMEBwUEBAABAncAAQIDEQQFITEGEkFRB2FxEyIygQgUQp"
"GhscEJIzNS8BVictEKFiQ04SXxFxgZGiYnKCkqNTY3ODk6Q0RFRkdIS"
"UpTVFVWV1hZWmNkZWZnaGlqc3R1dnd4eXqCg4SFhoeIiYqSk5SVlpeY"
"mZqio6Slpqeoqaqys7S1tre4ubrCw8TFxsfIycrS09TV1tfY2dri4+T"
"l5ufo6ery8/T19vf4+fr/2gAMAwEAAhEDEQA/AP38ooooA//Z")
png_b64 = (
"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAIAAAACAQMAAAB"
"IeJ9nAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAGUExURQAAAP///"
"6XZn90AAAAJcEhZcwAADsIAAA7CARUoSoAAAAAMSURBVBjTYzjAcAAAAwQBgXn"
"6PNcAAAAASUVORK5CYII=")
self.assert_runpy_result_and_response(
"user_error",
expected_msgs=[png_b64, jpeg_b64, "Figure1", "Figure 1",
"Figure3", "Figure 3", ],
Andreas Klöckner
committed
not_expected_msgs=[bmp_b64, "Figure2", "Figure 2"],
figures=[
[1, "image/png", png_b64],
[2, "image/bmp", bmp_b64],
[3, "image/jpeg", jpeg_b64]
]
)
def test_html_in_feedback(self):
html = "<ul><li>some html</li></ul>"
self.assert_runpy_result_and_response(
"user_error",
html,
html=[html]
)
js = "<script>console.log('good')</script>"
html_with_js = html + js
self.assert_runpy_result_and_response(
"user_error",
expected_msgs=html,
Andreas Klöckner
committed
not_expected_msgs=js, # js is sanitized
html=[html_with_js]
)
def test_html_audio(self):
b64_data = "T2dnUwACAAAAAAAAAAA+HAAAAAAAAGyawCEBQGZpc2h"
'<audio controls><source src="data:audio/wav;base64,'
'%s" type="audio/wav">'
'</audio>' % b64_data)
'<audio control><source src="data:audio/wav;base64,'
'%s" type="audio/wav">'
'</audio>' % b64_data)
'<audio controls><source href="data:audio/wav;base64,'
'%s" type="audio/wav">'
'</audio>' % b64_data)
'<audio><source src="data:audio/wav;base64,'
'%s" type="audio/wav">'
'</audio>' % b64_data)
'<audio controls><source src="data:audio/ogg;base64,'
'%s" type="audio/ogg">'
'</audio>' % b64_data)
'<audio controls><source src="hosse.wav" type="audio/wav">'
'</audio>')
html = [audio_valid, audio_invalid1, audio_invalid2, audio_invalid3,
audio_invalid4, audio_invalid5]
self.assert_runpy_result_and_response(
"user_error",
Andreas Klöckner
committed
not_expected_msgs=[audio_invalid1, audio_invalid2, audio_invalid3,
audio_invalid4, audio_invalid5],
html=html,
in_html=True
)
def test_html_img(self):
b64_data = ("iVBORw0KGgoAAAANSUhEUgAAAAIAAAACAQMAAAB"
"IeJ9nAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAGUExURQAAAP///"
"6XZn90AAAAJcEhZcwAADsIAAA7CARUoSoAAAAAMSURBVBjTYzjAcAAAAwQBgXn"
"6PNcAAAAASUVORK5CYII=")
'<img src="data:image/png;base64,%s" alt="test img" '
'title="test image">' % b64_data)
'<img src="data:image/png;base64,%s" '
'alt="test img" '
'width="126" '
'height="44">' % b64_data)
'<img href="data:image/png;base64,%s" '
'alt="test img" title="test image">' % b64_data)
'<img src="data:image/bmp;base64,%s" '
'alt="test img" title="test image">' % b64_data)
html = [img_valid, img_invalid1, img_invalid2, img_invalid3]
self.assert_runpy_result_and_response(
"user_error",
Andreas Klöckner
committed
not_expected_msgs=[img_invalid1, img_invalid2, img_invalid3],
html=html,
in_html=True,
)
Andreas Klöckner
committed
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
evil_b64_data = ("iVBORw0KGgoAAAANSUhEUgAAAAIAAAACAQMAAAB=")
evil_data_html_strings = [
'<a src="data:,Hello%2C%20Evil%20World!"></a>',
'<a href="data:,Hello%2C%20Evil%20World!"></a>',
'<a src="data:text/html;base64,%s"</a>' % evil_b64_data,
'<a src="data:text/html;base64,%s"</a>' % evil_b64_data,
'<img src="https://Evil.com">',
'<script src="data:text/html,<script>alert("Evil");</script>"',
'<script href="data:text/html,<script>alert("Evil");</script>"',
'<script src="data:text/html;base64,%s"</script>' % evil_b64_data,
'<script href="data:text/html;base64,%s"</script>' % evil_b64_data,
'<style src="data:,Evilcss">',
'<style href="data:,Evilcss">',
'<style src="data:image/png;base64,%s">' % evil_b64_data,
'<style href="data:image/png;base64,%s">' % evil_b64_data,
]
def test_html_from_code_sanitization(self):
from course.page.code import sanitize_from_code_html
for evhtml in self.evil_data_html_strings:
print("------------------")
print(evhtml)
sanitized = sanitize_from_code_html(evhtml)
print(sanitized)
assert "Evil" not in sanitized
def test_html_with_data_protocol_for_other_tags_sanitized(self):
# Fixed https://github.com/inducer/relate/issues/435
# Ref: https://github.com/mozilla/bleach/issues/348
self.assert_runpy_result_and_response(
"user_error",
Andreas Klöckner
committed
not_expected_msgs=self.evil_data_html_strings + [
"Evil", self.evil_data_html_strings],
html=self.evil_data_html_strings,
def test_html_non_text_bleached_in_feedback(self):
self.assert_runpy_result_and_response(
"user_error",
"(Non-string in 'HTML' output filtered out)",
html=b"not string"
)
# {{{ https://github.com/inducer/relate/pull/448
Dong Zhuang
committed
def test_feedback_points_close_to_1(self):
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": 1.000000000002,
"min_points": 0
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
resp = self.get_page_sandbox_submit_answer_response(
markdown,
answer_data={"answer": ['c = b + a\r']})
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, 1)
def test_feedback_code_exceed_1(self):
feedback_points = 1.1
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": feedback_points,
"min_points": 0
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
resp = self.get_page_sandbox_submit_answer_response(
markdown,
answer_data={"answer": ['c = b + a\r']})
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, 1.1)
expected_feedback = "Your answer is correct and earned bonus points."
self.assertResponseContextAnswerFeedbackContainsFeedback(
resp, expected_feedback)
def test_feedback_code_positive_close_to_0(self):
# https://github.com/inducer/relate/pull/448#issuecomment-363655132
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": 1,
"min_points": 0.00000000001
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
# Post a wrong answer
resp = self.get_page_sandbox_submit_answer_response(
markdown,
answer_data={"answer": ['c = b - a\r']})
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, 0)
def test_feedback_code_negative_close_to_0(self):
# https://github.com/inducer/relate/pull/448#issuecomment-363655132
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": 1,
"min_points": -0.00000000001
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
# Post a wrong answer
resp = self.get_page_sandbox_submit_answer_response(
markdown,
answer_data={"answer": ['c = b - a\r']})
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(resp, 0)
def test_feedback_code_error_close_below_max_auto_feedback_points(self):
feedback_points = MAX_EXTRA_CREDIT_FACTOR - 1e-6
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {
"full_points": feedback_points,
"min_points": 0
})
resp = self.get_page_sandbox_preview_response(markdown)
self.assertEqual(resp.status_code, 200)
self.assertSandboxHasValidPage(resp)
resp = self.get_page_sandbox_submit_answer_response(
markdown,
answer_data={"answer": ['c = b + a\r']})
self.assertEqual(resp.status_code, 200)
self.assertResponseContextAnswerFeedbackCorrectnessEquals(
resp, MAX_EXTRA_CREDIT_FACTOR)
def test_feedback_code_error_close_above_max_auto_feedback_points(self):
feedback_points = MAX_EXTRA_CREDIT_FACTOR + 1e-6
markdown = (markdowns.FEEDBACK_POINTS_CODE_MARKDWON_PATTERN
% {