Skip to content

Make sure qbx_order is provided

Alexandru Fikl requested to merge fikl2/pytential:qbx-order-check into master

This is more of a RFC, since I'm not quite sure if this is correct. From what I can tell, there are a couple of tests that use QBXLayerPotentialSource without a qbx_order that seem fine, since they just refine the geometry.

So:

  • if qbx_order is a hard requirement, wouldn't it make more sense to make it a proper positional argument?
  • if it's not, maybe a warning would suffice? Otherwise I could add the check just to the functions that actually use it, like exec_compute_potential_insn_fmm, etc.

Merge request reports