Skip to content
Commit a6381144 authored by Matt Wala's avatar Matt Wala
Browse files

A few fixes. 

1) Document refiner.
2) Get helmholtz parameter based refinement working.
3) Fix curve smoothness (needs scipy dependency).
parent a50edb8d
Pipeline #2249 failed with stage
in 9 minutes and 26 seconds
Hide whitespace changes
Inline Side-by-side
  • Andreas Klöckner @inducer ·
    Owner

    @mattwala

    • Add a pytest.importorskip("scipy") to let the tests succeed even if scipy's not available.
    • Toss scipy into requirements.txt to make sure it gets installed and those tests actually run.
  • Andreas Klöckner @inducer ·
    Owner

    Also: What exactly does the spline-ing accomplish? Feels voodoo-ey...

  • Matt Wala @mattwala ·
    Author Maintainer

    The main issue seems to be that if a panel crosses one of the points in the horseshoe where there is a transition between curved / straight pieces, then the refiner will keep refining into that panel. The spline-y bit was supposed to smooth out those crossing points. I decided it was not worth the trouble. There doesn't seem to be a problem when the crossing point is on a panel boundary.

  • Matt Wala @mattwala ·
    Author Maintainer

    (see b8d4547b)

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment