* add clone_for_callee to CopyMapperWithExtraArgs

* add TransformMapper/TransformMapperWithExtraArgs

* make CopyMapper/CopyMapperWithExtraArgs inherit from TransformMapper/TransformMapperWithExtraArgs

* expand on purpose of TransformMapper in docstring

* Add node counter tests

* CI fixes

* Add comments

* Remove unnecessary test

* Add duplicate node functionality and tests

* Remove incrementation for DictOfNamedArrays and update tests

* Edit tests to account for not counting DictOfNamedArrays

* Fix CI tests

* Fix comments

* Clarify wording and clean up

* Move `get_node_multiplicities` to its own mapper

* Add autofunction

* Linting

* Add Dict typedef and format

* Format further

* Fix CI errors

* Fix wording

* Implement new DAG generator with guaranteed duplicates

* Apply suggestions from code review

Co-authored-by: Matt Smith <mjsmith1@gmail.com>

* Ruff fixes

* remove prints

* Apply suggestions from code review

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* Add explicit bool for count_duplicates

* Update test/testlib.py

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* Seed random

---------

Co-authored-by: Matt Smith <mjsmith1@gmail.com>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Matt Smith <mjsmith6@illinois.edu>

* Remove the index_access_descr from Einsum object.

* Ruff corrections.

* Make the index_to_access_descriptor a cached property that will automatically build a dictionary for strings to access descriptor. Note that this may not be the exact same string as what the user passed in pt.einsum, but will be equivalent.

* Add a comment on the new cached property.

* Fixing comments made by ruff.

* Remove the cached property. Add in a warning to users requesting a subscript string.

* Remove duplicated code in generating a einsum string. The numpy code generator returned a string which contained spaces after the punctuation. It now no longer does.

* Numpy code generator seems to be dependent on the spaces after the punctuation. So, I am adding those back in.

* Deprecate the old function get_einsum_subscript_str, in favor of get_einsum_specification. Update the code to use the new function.

* Visualization needed to be updated as well.

* Update pytato/utils.py

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* Update pytato/utils.py

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* Updates target.

* Update the documentation to be more clear.

* Fixed a typo.

* Remove excess assert statement.

* Ensure there is a unique error message for arguments of string type since we are removing that functionality.

---------

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* add missing *args, **kwargs in WalkMapper.map_call

* memoize clone_for_callee

* remove default CombineMapper map_call implementation

* don't memoize map_function_definition in cached walk mappers

doesn't make sense, since it doesn't return anything

* support calls in InputGatherer

* make NamedCallResult compatible with attrs cache_hash=True

* enable cache_hash on FunctionDefinition

* enable calls in DirectPredecessorsGetter

* memoize Call creation

* make NamedCallResult.call a property

* remove redundant NamedCallResult.name (already defined in NamedArray)

* memoize NamedCallResult creation

* fix docstring

* remove non-argument placeholder check

now done in arraycontext

* fix equality for FunctionDefinition

* add FIXME

* attempt to fix doc warning

* don't construct NamedCallResult directly

* fix mapper method name in UsersCollector

* add FIXME

* Revert "add FIXME"

This reverts commit 72bf01daf4757c72560c5eaf937377b57ce6b07d.

* Revert "remove non-argument placeholder check"

This reverts commit 73478bc4ac16877f946ce868317d9d1d10fb2ca6.

* add some more missing *args, **kwargs to WalkMapper

* remove some unnecessary *args, **kwargs

* add get_func_def_cache_key to walk mappers to correctly handle function caching when extra arguments are present

* undo memoizing Call creation

* don't use regular dict for function call results

* fix type annotation for function result

* undo memoizing clone_for_callee

doesn't avoid retraversal when the same function is encountered inside the bodies of two different
functions

* add SizeParamGatherer.map_call

default map_call implementation was removed from CombineMapper, so it needs to be here

* Revert "add get_func_def_cache_key to walk mappers to correctly handle function caching when extra arguments are present"

This reverts commit 45eb68d54d6b0e74776fa9bde8d41c7f798b8c49.

* Revert "don't memoize map_function_definition in cached walk mappers"

This reverts commit c0e70cdc8821ae7b14c31acf38e996cdf6bd5896.

This reverts commit dd6a35b6.

Andreas Klöckner authored 8 months ago and Andreas Klöckner committed 8 months ago

Closes gh-509

dependabot[bot] authored 11 months ago and Andreas Klöckner committed 11 months ago

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4

)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add tag to store array creation traceback

* don't make it a unique tag

* adds a common _get_default_tags

* Change back to UniqueTag

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* use _get_default_tags

* store a tupleized StackSummary

* work around mypy

* more line fixes

* use a class for the traceback instead of tuples

* also test to_stacksummary

* flake8

* Add remove_tags_of_type

* test_array_dot_repr: Remove CreatedAt tags before comparing

* only add CreatedAt in debug mode

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* restructure test_created_at

* make _PytatoStackSummary a dataclass

* add __repr__

* fix 2 tests

* illustrate test failure with construct_intestine_graph

* shorten traceback printing

* use separate field for CreatedAt

* fix tests

* fix doctest

* make it a tag again

* use tooltip instead of table row

* force openmpi usage

* check for existing CreatedAt and make it a UniqueTag again

* flake8

* add simple equality test

* lint fixes

* add InfoTag class and filter tags based on it

* fix doc

* another doc fix

* use IgnoredForEqualityTag

* UNDO BEFORE MERGE: use external project branches

* Revert "UNDO BEFORE MERGE: use external project branches"

This reverts commit 71dd791b45cee918d33ac8c4cb8e9a3cf643ec37.

* Revert "use IgnoredForEqualityTag"

This reverts commit cd67d684d1c777bc3efef080031446e033e75f42.

* rename InfoTag -> IgnoredForEqualityTag

* more stringent tests

* undo unnecessary test changes

* Revert "Revert "use IgnoredForEqualityTag""

This reverts commit bfb22ba66d0872c3848a4ab41260f9f82ffa188d.

* simplify condition

* Revert "simplify condition"

This reverts commit 1111b7915e23561161eee132e8d5ccb716b101eb.

* bump pytools version + a few spelling fixes

* remove duplicated self.axes in hash()

* use Taggable{__eq__,__hash__}

* add another test

* add vis test

* make _PytatoFrameSummary, _PytatoStackSummary undocumented

* use Taggable.__hash__ for tags in Array.__hash__

* change dataclass to attrs

* flake8

* Taggable.__eq__

* add Array.tagged()

* restrict to DEBUG_ENABLED

* force DEBUG_ENABLED for test

* work around mypy/attrs issue

* fix for fields

* undo mypy ignores

* rewrite to use a new field in Array, non_equality_tags

* misc fixes

* undo some unecessary changes

* more misc fixes

* copymapper, tests

* explicitly enable/disable traceback

* add hash test

* undo more unnecessary changes

* more lint fixes

* run all examples, fix demo_distributed_node_duplication

* enable CreatedAt for distributed nodes

* add support for make_distributed_send_ref_holder

* add to MPMSMaterializer

* Get precise traceback of array creation (#480)

* rename enable_traceback_tag

Co-authored-by: Andreas Klöckner <inform@tiker.net>

* remove update_persistent_hash

* improve doc of _PytatoFrameSummary, _PytatoStackSummary

* move _Pytato{Frame,Stack}Summary to tags, convert to dataclass

* add AxisPermutation CreatedAt

* fix doc

* make _get_created_at_tag return a frozenset

---------

Co-authored-by: Kaushik Kulkarni <kaushikcfd@gmail.com>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Matt Smith <mjsmith6@illinois.edu>