Skip to content
Unverified Commit b8dd7aef authored by Kaushik Kulkarni's avatar Kaushik Kulkarni Committed by GitHub
Browse files

Make pt.(Placeholder|SizeParam) equality comparable (#123)



* make pt.(Placeholder|SizeParam) equality comparable

The only input argument for which it makes sense to have identity comparison is
data wrappers to that the DAG comparisons are efficient. This also led to some
downstream re-writing of mappers's cache keys that relied on object equality.

* Placeholder without a name is moot

No sensible program would actually needed a non-named placeholder.

* fixup! make pt.(Placeholder|SizeParam) equality comparable

* adds a note about DataWrapper.__eq__'s implementation

* fixup! make pt.(Placeholder|SizeParam) equality comparable

* Clarify DataWrapper equality definition

* Clarify comment explaining use of id() for CachedWalkMapper

Co-authored-by: default avatarAndreas Klöckner <inform@tiker.net>
parent ffc467ac
Loading
Loading
Loading
Pipeline #187377 passed with stage
in 4 minutes and 50 seconds
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment