Better empty handling (!113) · Merge requests · Andreas Klöckner / pyopencl · GitLab

Snippets Groups Projects

Merged Andreas Klöckner requested to merge better-empty-handling into master 4 years ago

All threads resolved!

@mattwala Could you take a look?

Activity

Andreas Klöckner mentioned in merge request loopy!354 (merged) 4 years ago

mentioned in merge request loopy!354 (merged)
Andreas Klöckner mentioned in merge request loopy!396 (merged) 4 years ago

mentioned in merge request loopy!396 (merged)
Matt Wala @mattwala started a thread on the diff 4 years ago

Resolved 4 years ago by Matt Wala
Last reply by Matt Wala 4 years ago

Matt Wala @mattwala · 4 years ago

Developer

Resolved 4 years ago by Matt Wala

This is missing tests.
Last reply by Matt Wala 4 years ago

Matt Wala resolved all threads 4 years ago

resolved all threads

Andreas Klöckner added 5 commits 4 years ago

added 5 commits

5c165817 - Use CI variable for project name in Github CI
673f1357 - Use CI variable for project name in Gitlab CI
80845168 - Test, fix allocator behavior for zero-size allocations
299612cf - Test, fix zero-size arrays
ee4acf30 - Test allow_empty_ndrange in kernel enqueue

Compare with previous version

Toggle commit list

Andreas Klöckner added 1 commit 4 years ago

added 1 commit

c5a2b5fd - Bump invoker cache version

Compare with previous version

Matt Wala @mattwala started a thread on the diff 4 years ago

Resolved 4 years ago by Andreas Klöckner

Matt Wala @mattwala started a thread on an old version of the diff 4 years ago

Resolved 4 years ago by Andreas Klöckner

Matt Wala @mattwala · 4 years ago

Developer

lgtm

Matt Wala @mattwala · 4 years ago

Developer

I left some small suggestions.

Andreas Klöckner added 1 commit 4 years ago

added 1 commit

ddbb4a6c - Apply suggestion to src/wrap_mempool.cpp

Compare with previous version

Andreas Klöckner added 1 commit 4 years ago

added 1 commit

625e9a50 - test_empty_ndrange: twice->add_two

Compare with previous version

Andreas Klöckner resolved all threads 4 years ago

resolved all threads

Andreas Klöckner merged 4 years ago

merged

Andreas Klöckner mentioned in commit 4 years ago

mentioned in commit 8395a493

Andreas Klöckner @inducer · 4 years ago

Author Owner

Forgot to say: Thanks for taking a look!

Please register or sign in to reply