Suggested style fixes for data fixtures

mentioned in merge request !29 (merged)

I like this approach in general. I'm concerned about prefixing functions with test_ unless they are actual tests that will run (since I think this is the criteria for how pytest scans for test functions). What about flux_data_fixture instead of test_flux_data_fixture?

I feel that the name test_data.py is very descriptive, however it's my impression that similarly to above, pytest will look in modules prefixed with test_ for test functions to run, so I'd prefer not to have a module prefixed with test_ unless it actually contains test functions. What about input_data.py?

added 3 commits

• 55a528e6 - Rename test_data to avoid pytest confusion
• 266f95dc - Flake8 fixes
• e9868619 - Rename test_flux_data_fixture -> flux_test_data_fixture to avoid pytest confusion

Compare with previous version

How about now?

added 1 commit

• 7f1e9131 - Fix an incorrect fixture argument

Compare with previous version

enabled an automatic merge when the pipeline for 7f1e9131 succeeds

resolved all threads

merged

mentioned in commit a3dcc093