Skip to content
Snippets Groups Projects
Commit ffe96d2a authored by Timothy A. Smith's avatar Timothy A. Smith
Browse files

add some FIXME notes

parent 685ddd5c
No related branches found
No related tags found
1 merge request!36WENO interface update
......@@ -7,6 +7,9 @@ import reference_implementation as ref
# {{{ FluxDataSingle
class FluxDataSingle:
# FIXME: can we set some of these constants from ref.gas?
# -- if all nvars references come from there, it's relatively easy to
# introduce a new gas with more (e.g. scalar) variables
nvars = 5
ndim = 3
dirs = {"x": 1, "y": 2, "z": 3}
......@@ -25,6 +28,10 @@ class FluxDataSingle:
self.frozen_jacobian = np.mean(self.jacobians[2:4], axis=0)
self.combined_frozen_metrics = 1.0
# FIXME: Move array_from_string stuff outside FluxDataSingle
# -- just pass an array & have external utilities that generate
# Riemann, sine wave, etc. initial conditions
# FIXME: Consider handling row swapping outside as well?
self.state_pair = self.swap_array_rows(
u.transposed_array_from_string(states_str), self.dir_internal)
self.states = u.expand_to_n(self.state_pair, 6)
......@@ -77,6 +84,7 @@ class FluxDataSingle:
# {{{ FluxDataVector
# FIXME: is there a better way to divide responsibilities with these fixture classes?
class FluxDataVector:
nvars = 5
ndim = 3
......@@ -103,6 +111,7 @@ class FluxDataVector:
self.states = self.fill_transverse_with_halo(
u.expand_to_n(state_pair, self.nxhalo))
# FIXME: convert all this stuff to reference implementation
flux_pair = self.swap_array_rows(
u.transposed_array_from_string(fluxes_str), self.direction)
self.fluxes = self.fill_transverse_with_halo(
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment