Skip to content
Unverified Commit af68e2d3 authored by Matt Smith's avatar Matt Smith Committed by GitHub
Browse files

Use elementwise size in node vertex consistency check (#316)



* use elementwise size in node vertex consistency check

* add comment explaining maximum(..., 1)

* use test based on maximum absolute vertex coordinate instead of element size, and add tests

* assume absolute and relative tolerances are the same for now

* add test for false negatives

* zero-size -> zero-D

* improve vertex consistency check error message

* use a specific exception type for consistency check

* improve tests

* just use relative tolerance and skip dim==0 case

* only do consistency check in debug run

* Reenable 0D tests, remove 1e-5 crit tol scaling, take into account abs tol in node-vert-consistency test tests

Co-authored-by: default avatarAndreas Kloeckner <inform@tiker.net>
parent e7613aec
Pipeline #339774 passed with stage
in 1 hour, 38 minutes, and 21 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment