Make a way to spell literal local barriers

@jdsteve2

@mattwala I dimly recall that we didn't want this when we introduced the global barrier literals, but @jdsteve2 needed it to generate benchmark kernels. Do you remember a good reason not to have this?

added 1 commit

• 9ec39bd9 - Make sure all Barrier schedule items have originating_insn_id

Compare with previous version

I don't see any problems with it, but you will need to fix the scheduler here

It assumes that local barriers in the preschedule do not have an originating instruction and handles them specially. If local barriers in the preschedule do have an originating instruction I imagine this will break.

I think removing line 819 should fix this issue and changing the above linked section to distinguish between barriers that do/do not have an originating instruction.

added 1 commit

• ae1ef803 - Fix scheduler for incremental scheduling of literal local barriers.

Compare with previous version

resolved all discussions

I made the scheduler changes I was talking about in ae1ef803

Thanks! Turns out I was working on the very same thing when I saw the "pipeline pending" notification...

merged

mentioned in commit 91513dcf

Woops, should have let you know. Sorry for the overlap in work

Np, thanks for working on it.

@inducer @mattwala Thanks guys! This was really helpful.