Skip to content
Commit 11df03be authored by Cory Mikida's avatar Cory Mikida
Browse files

Pull bounds out of encompassing structures before entering loop

parent 50f3b163
Loading
Loading
Loading
Pipeline #6676 failed with stage
in 34 seconds
Loading
  • Author Developer

    A slightly hacky thing with this - using the whole dimension name to define a Fortran name turned out to produce a variable that Fortran finds to be too long, so for right now I'm just (somewhat arbitrarily) taking the last six characters of the name. This is something I can probably fix.

  • @cory A few points:

    • It's good practice to name branches by what they implement rather than by who made them. (Git keeps track of authorship anyhow.) (No need to rename this one though.) This could have been fortran-extract-loop-bounds or some such.
    • Please create a merge request from this branch into master. Keep this marked as "Work in Progress" until it's ready to merge. (Conversely, it's fine to put up half-finished work as long as it's marked as such, so Matt or I don't review it before it's finished.) The MR creates one place to keep track of changes/issues over multiple revisions of the work.
    • The tests failed--could you take a look?
  • Author Developer

    Yeah, I'm looking into it now. The tests appear to be failing because of syntax issues. Sorry for the noise! I'll make a merge request into master as well.

0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment