From c12c9bbe7a88c58acba3a39243440812223f31d2 Mon Sep 17 00:00:00 2001 From: Andreas Kloeckner Date: Tue, 20 Sep 2016 14:56:07 -0500 Subject: [PATCH] Advise about ineffective permissions for non-in-progress flows --- course/validation.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/course/validation.py b/course/validation.py index 24cf56c0..828ad5ad 100644 --- a/course/validation.py +++ b/course/validation.py @@ -659,6 +659,16 @@ def validate_session_access_rule(vctx, location, arule, tags): "%s, permission %d" % (location, j+1), perm) + if hasattr(arule, "if_in_progress") and not arule.if_in_progress: + from course.constants import flow_permission + if ( + flow_permission.submit_answer in arule.permissions + or flow_permission.end_session in arule.permissions): + vctx.add_warning(location, + _("Rule specifies 'submit_answer' or 'end_session' " + "permissions for non-in-progress flow. These " + "permissions will be ignored.")) + def validate_session_grading_rule( vctx, # type: ValidationContext -- GitLab