Newer
Older
from __future__ import division, print_function
__copyright__ = "Copyright (C) 2014 Andreas Kloeckner"
__license__ = """
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
"""
import re
import datetime
import six
from django.core.exceptions import ObjectDoesNotExist
from django.utils.html import escape
from course.content import get_repo_blob
from courseflow.utils import Struct
# {{{ validation tools
class ValidationError(RuntimeError):
pass
ID_RE = re.compile(r"^[\w]+$")
def validate_identifier(location, s):
if not ID_RE.match(s):
raise ValidationError("%s: invalid identifier '%s'"
% (location, s))
def validate_role(location, role):
from course.constants import participation_role
if role not in [
participation_role.instructor,
participation_role.teaching_assistant,
participation_role.student,
participation_role.unenrolled,
]:
raise ValidationError("%s: invalid role '%s'"
% (location, role))
def validate_struct(ctx, location, obj, required_attrs, allowed_attrs):
"""
:arg required_attrs: an attribute validation list (see below)
:arg allowed_attrs: an attribute validation list (see below)
An attribute validation list is a list of elements, where each element is
either a string (the name of the attribute), in which case the type of each
attribute is not checked, or a tuple *(name, type)*, where type is valid
as a second argument to :func:`isinstance`.
"""
present_attrs = set(name for name in dir(obj) if not name.startswith("_"))
for required, attr_list in [
(True, required_attrs),
(False, allowed_attrs),
]:
for attr_rec in attr_list:
if isinstance(attr_rec, tuple):
attr, allowed_types = attr_rec
else:
attr = attr_rec
allowed_types = None
if attr not in present_attrs:
if required:
raise ValidationError("%s: attribute '%s' missing"
% (location, attr))
else:
present_attrs.remove(attr)
val = getattr(obj, attr)
is_markup = False
if allowed_types == "markup":
allowed_types = str
is_markup = True
if allowed_types == str:
# Love you, too, Python 2.
allowed_types = (str, unicode)
if not isinstance(val, allowed_types):
raise ValidationError("%s: attribute '%s' has "
"wrong type: got '%s', expected '%s'"
% (location, attr, type(val).__name__,
if is_markup:
validate_markup(ctx, "%s: attribute %s" % (location, attr), val)
if present_attrs:
raise ValidationError("%s: extraneous attribute(s) '%s'"
% (location, ",".join(present_attrs)))
datespec_types = (datetime.date, six.string_types)
# }}}
Andreas Klöckner
committed
class ValidationWarning(object):
def __init__(self, location, text):
self.location = location
self.text = text
"""
.. attribute:: repo
.. attribute:: commit_sha
.. attribute:: datespec_callback
a function that is supposed to be called on all encountered datespecs
"""
def __init__(self, repo, commit_sha, datespec_callback=None):
self.repo = repo
self.commit_sha = commit_sha
self.datespec_callback = datespec_callback
Andreas Klöckner
committed
self.warnings = []
def encounter_datespec(self, location, datespec):
if self.datespec_callback is not None:
Andreas Klöckner
committed
def add_warning(self, *args, **kwargs):
self.warnings.append(ValidationWarning(*args, **kwargs))
def validate_markup(ctx, location, markup_str):
def reverse_func(*args, **kwargs):
pass
from course.content import markup_to_html
try:
markup_to_html(
course=None,
repo=ctx.repo,
commit_sha=ctx.commit_sha,
Andreas Klöckner
committed
reverse_func=reverse_func,
validate_only=True)
from traceback import print_exc
print_exc()
raise ValidationError("%s: %s: %s" % (
def validate_chunk_rule(ctx, location, chunk_rule):
chunk_rule,
required_attrs=[
("weight", int),
],
allowed_attrs=[
("start", (str, datetime.date)),
("end", (str, datetime.date)),
("role", str),
if hasattr(chunk_rule, "start"):
ctx.encounter_datespec(location, chunk_rule.start)
if hasattr(chunk_rule, "end"):
ctx.encounter_datespec(location, chunk_rule.end)
if hasattr(chunk_rule, "role"):
ctx.add_warning(location, "Uses deprecated 'role' attribute--"
"use 'roles' instead")
validate_role(location, chunk_rule.role)
if hasattr(chunk_rule, "roles"):
for role in chunk_rule.roles:
validate_role(location, role)
def validate_chunk(ctx, location, chunk):
chunk,
required_attrs=[
("title", str),
("id", str),
("rules", list),
("content", "markup"),
for i, rule in enumerate(chunk.rules):
validate_chunk_rule(ctx,
"%s, rule %d" % (location, i+1),
rule)
def validate_course_desc_struct(ctx, location, course_desc):
course_desc,
required_attrs=[
("name", str),
("number", str),
("run", str),
("chunks", list),
],
allowed_attrs=[]
)
for i, chunk in enumerate(course_desc.chunks):
validate_chunk(ctx,
"%s, chunk %d ('%s')"
% (location, i+1, getattr(chunk, "id", None)),
# {{{ check chunk id uniqueness
chunk_ids = set()
for chunk in course_desc.chunks:
if chunk.id in chunk_ids:
raise ValidationError("%s: chunk id '%s' not unique"
% (location, chunk.id))
chunk_ids.add(chunk.id)
# }}}
# }}}
# {{{ flow validation
def validate_flow_page(ctx, location, page_desc):
if not hasattr(page_desc, "id"):
raise ValidationError("%s: flow page has no ID" % location)
validate_identifier(location, page_desc.id)
from course.content import get_flow_page_class
class_ = get_flow_page_class(ctx.repo, page_desc.type, ctx.commit_sha)
class_(ctx, location, page_desc)
except ValidationError:
raise
from traceback import format_exc
"%s: could not instantiate flow page: %s: %s<br><pre>%s</pre>"
% (location, tp.__name__, str(e), format_exc()))
def validate_flow_group(ctx, location, grp):
validate_struct(
location,
grp,
required_attrs=[
("id", str),
("pages", list),
],
allowed_attrs=[]
)
# {{{ check page id uniqueness
page_ids = set()
for page_desc in grp.pages:
if page_desc.id in page_ids:
raise ValidationError("%s: page id '%s' not unique"
% (location, page_desc.id))
page_ids.add(page_desc.id)
# }}}
for i, page_desc in enumerate(grp.pages):
validate_flow_page(
ctx,
"%s, page %d ('%s')"
% (location, i+1, getattr(page_desc, "id", None)),
page_desc)
validate_identifier(location, grp.id)
def validate_flow_permission(ctx, location, permission):
from course.constants import FLOW_PERMISSION_CHOICES
if permission not in dict(FLOW_PERMISSION_CHOICES):
raise ValidationError("%s: invalid flow permission '%s'"
% (location, permission))
def validate_flow_access_rule(ctx, location, rule):
validate_struct(
location,
rule,
required_attrs=[
("permissions", list),
],
allowed_attrs=[
("roles", list),
("start", (datetime.date, str)),
("end", (datetime.date, str)),
("credit_percent", (int, float)),
("allowed_session_count", int),
]
)
for i, perm in enumerate(rule.permissions):
validate_flow_permission(
ctx,
"%s, permission %d" % (location, i+1),
perm)
if hasattr(rule, "roles"):
for i, role in enumerate(rule.roles):
validate_role(
"%s, role %d" % (location, i+1),
role)
if hasattr(rule, "start"):
if hasattr(rule, "end"):
if not hasattr(rule, "id"):
ctx.add_warning(location,
"Access rule is missing 'id' attribute. "
"This will become required in 2015.x.")
def validate_flow_desc(ctx, location, flow_desc):
validate_struct(
location,
flow_desc,
required_attrs=[
("title", str),
("description", "markup"),
("completion_text", "markup"),
],
allowed_attrs=[
("access_rules", list),
("grade_aggregation_strategy", str),
("sticky_versioning", bool),
encountered_permissions = set()
if hasattr(flow_desc, "access_rules"):
for i, rule in enumerate(flow_desc.access_rules):
validate_flow_access_rule(ctx,
"%s, access rule %d" % (location, i+1),
rule)
encountered_permissions.update(rule.permissions)
last_rule = flow_desc.access_rules[-1]
if (
hasattr(last_rule, "roles")
or hasattr(last_rule, "start")
or hasattr(last_rule, "end")
):
raise ValidationError("%s: last access rule must set default access "
"(i.e. have no attributes other than 'permissions')"
% location)
if not hasattr(flow_desc, "sticky_versioning"):
ctx.add_warning(location, "Flow is missing 'sticky_versioning' attribute - "
"this will be required in 2015.x.")
if hasattr(flow_desc, "grade_aggregation_strategy"):
from course.constants import GRADE_AGGREGATION_STRATEGY_CHOICES
if flow_desc.grade_aggregation_strategy not in \
dict(GRADE_AGGREGATION_STRATEGY_CHOICES):
raise ValidationError("%s: invalid grade aggregation strategy"
% location)
else:
from course.constants import flow_permission
if flow_permission.start_credit in encountered_permissions:
raise ValidationError(
"%s: flow which can be used for credit must have "
"grade_aggregation_strategy"
% location)
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
# {{{ check for non-emptiness
flow_has_page = False
for i, grp in enumerate(flow_desc.groups):
group_has_page = False
for page in grp.pages:
group_has_page = flow_has_page = True
break
if not group_has_page:
raise ValidationError("%s, group %d ('%d'): no pages found"
% (location, i+1, grp.id))
if not flow_has_page:
raise ValidationError("%s: no pages found"
% location)
# }}}
# {{{ check group id uniqueness
group_ids = set()
for grp in flow_desc.groups:
if grp.id in group_ids:
raise ValidationError("%s: group id '%s' not unique"
% (location, grp.id))
group_ids.add(grp.id)
# }}}
for i, grp in enumerate(flow_desc.groups):
validate_flow_group(ctx, "%s, group %d ('%s')"
% (location, i+1, grp.id),
grp)
validate_markup(ctx, location, flow_desc.description)
validate_markup(ctx, location, flow_desc.completion_text)
# {{{ calendar validation
def validate_calendar_desc_struct(ctx, location, events_desc):
validate_struct(
location,
events_desc,
required_attrs=[
],
allowed_attrs=[
("event_kinds", Struct),
("events", Struct),
]
)
# FIXME could do more here
# }}}
def get_yaml_from_repo_safely(repo, full_name, commit_sha):
from course.content import get_yaml_from_repo
return get_yaml_from_repo(
repo=repo, full_name=full_name, commit_sha=commit_sha,
cached=False)
from traceback import print_exc
print_exc()
raise ValidationError("%s: %s: %s" % (
full_name, tp.__name__, str(e)))
def validate_course_content(repo, course_file, events_file,
validate_sha, datespec_callback=None):
course_desc = get_yaml_from_repo_safely(repo, course_file,
commit_sha=validate_sha)
ctx = ValidationContext(
repo=repo,
commit_sha=validate_sha,
datespec_callback=datespec_callback)
validate_course_desc_struct(ctx, course_file, course_desc)
try:
from course.content import get_yaml_from_repo
events_desc = get_yaml_from_repo(repo, events_file,
commit_sha=validate_sha, cached=False)
except ObjectDoesNotExist:
# That's OK--no calendar info.
pass
else:
validate_calendar_desc_struct(ctx, events_file, events_desc)
try:
flows_tree = get_repo_blob(repo, "flows", validate_sha)
except ObjectDoesNotExist:
# That's OK--no flows yet.
pass
else:
for entry in flows_tree.items():
if not entry.path.endswith(".yml"):
continue
location = "flows/%s" % entry.path
flow_desc = get_yaml_from_repo_safely(repo, location,
validate_flow_desc(ctx, location, flow_desc)
Andreas Klöckner
committed
return ctx.warnings
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
# {{{ validation script support
class FileSystemFakeRepo(object):
def __init__(self, root):
self.root = root
def __getitem__(self, sha):
return sha
@property
def tree(self):
return FileSystemFakeRepoTree(self.root)
class FileSystemFakeRepoTreeEntry(object):
def __init__(self, path):
self.path = path
class FileSystemFakeRepoTree(object):
def __init__(self, root):
self.root = root
def __getitem__(self, name):
from os.path import join, isdir, exists
name = join(self.root, name)
if not exists(name):
raise ObjectDoesNotExist(name)
# returns mode, "sha"
if isdir(name):
return None, FileSystemFakeRepoTree(name)
else:
return None, FileSystemFakeRepoFile(name)
def items(self):
import os
return [FileSystemFakeRepoTreeEntry(n) for n in os.listdir(self.root)]
class FileSystemFakeRepoFile(object):
def __init__(self, name):
self.name = name
@property
def data(self):
with open(self.name, "rb") as inf:
return inf.read()
def validate_course_on_filesystem_script_entrypoint():
import os
import argparse
parser = argparse.ArgumentParser(description='Process some integers.')
parser.add_argument("--course-file", default="course.yml")
parser.add_argument("--events-file", default="events.yml")
parser.add_argument('root', default=os.getcwd())
args = parser.parse_args()
fake_repo = FileSystemFakeRepo(args.root)
warnings = validate_course_content(
fake_repo,
args.course_file, args.events_file,
validate_sha=fake_repo, datespec_callback=None)
if warnings:
print("WARNINGS:")
for w in warnings:
print("***", w.location, w.text)