Skip to content
grading.py 17.3 KiB
Newer Older
from __future__ import annotations
Andreas Klöckner's avatar
Andreas Klöckner committed

Andreas Klöckner's avatar
Andreas Klöckner committed
__copyright__ = "Copyright (C) 2014 Andreas Kloeckner"

__license__ = """
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
"""

from typing import TYPE_CHECKING, Any
Andreas Klöckner's avatar
Andreas Klöckner committed

from django import http
from django.contrib import messages
from django.core.exceptions import (
    ObjectDoesNotExist,
    PermissionDenied,
    SuspiciousOperation,
Andreas Klöckner's avatar
Andreas Klöckner committed
)
from django.shortcuts import get_object_or_404, redirect, render  # noqa
Andreas Klöckner's avatar
Andreas Klöckner committed
from django.utils.translation import gettext as _
Andreas Klöckner's avatar
Andreas Klöckner committed
from course.constants import participation_permission as pperm
Andreas Klöckner's avatar
Andreas Klöckner committed
from course.models import (
    FlowPageVisitGrade,
    FlowSession,
    get_feedback_for_grade,
    get_flow_grading_opportunity,
    update_bulk_feedback,
Andreas Klöckner's avatar
Andreas Klöckner committed
)
from course.page import InvalidPageData
Andreas Klöckner's avatar
Andreas Klöckner committed
from course.utils import (
    FlowPageContext,
    course_view,
    get_session_grading_rule,
    render_course_page,
Andreas Klöckner's avatar
Andreas Klöckner committed
)
from course.views import get_now_or_fake_time
Andreas Klöckner's avatar
Andreas Klöckner committed
from relate.utils import (
    retry_transaction_decorator,
Andreas Klöckner's avatar
Andreas Klöckner committed
)
Andreas Klöckner's avatar
Andreas Klöckner committed
# {{{ for mypy

    import datetime
Andreas Klöckner's avatar
Andreas Klöckner committed

    from django.db.models import query
Andreas Klöckner's avatar
Andreas Klöckner committed

    from course.models import GradingOpportunity
    from course.utils import CoursePageContext
Andreas Klöckner's avatar
Andreas Klöckner committed

Andreas Klöckner's avatar
Andreas Klöckner committed
# }}}

def get_prev_visit_grades(
            course_identifier: str,
            flow_session_id: int,
            page_ordinal: int,
            reversed_on_visit_time_and_grade_time: bool | None = False
    order_by_args: list[str] = []
    if reversed_on_visit_time_and_grade_time:
        order_by_args = ["-visit__visit_time", "-grade_time"]
    return (FlowPageVisitGrade.objects
            .filter(
                visit__flow_session_id=flow_session_id,
                visit__page_data__page_ordinal=page_ordinal,
                visit__is_submitted_answer=True,
                visit__flow_session__course__identifier=course_identifier)
            .order_by(*order_by_args)
            .select_related("visit"))


@course_view
def get_prev_grades_dropdown_content(pctx, flow_session_id, page_ordinal,
                                     prev_grade_id):
    """
    :return: serialized prev_grades items for rendering past-grades-dropdown
    """
    request = pctx.request
Andreas Klöckner's avatar
Andreas Klöckner committed
    if request.method != "GET":
        raise PermissionDenied()

    if not pctx.participation:
        raise PermissionDenied(_("may not view grade book"))
    if not pctx.participation.has_permission(pperm.view_gradebook):
        raise PermissionDenied(_("may not view grade book"))

    page_ordinal = int(page_ordinal)
    flow_session_id = int(flow_session_id)

    prev_grades = get_prev_visit_grades(pctx.course_identifier,
                                        flow_session_id, page_ordinal, True)
    return render(pctx.request, "course/prev-grades-dropdown.html", {
                      "prev_grades": prev_grades,
                      "prev_grade_id": (
                          None
                          if prev_grade_id == "None" else
                          int(prev_grade_id)),
                  })
Andreas Klöckner's avatar
Andreas Klöckner committed
@course_view
def grade_flow_page(
        pctx: CoursePageContext,
        flow_session_id: int,
        page_ordinal: int
        ) -> http.HttpResponse:
    now_datetime = get_now_or_fake_time(pctx.request)

    page_ordinal = int(page_ordinal)
    viewing_prev_grade = False
    prev_grade_id_str = pctx.request.GET.get("grade_id")
    if prev_grade_id_str is not None:
            prev_grade_id = int(prev_grade_id_str)
            viewing_prev_grade = True
        except ValueError:
            raise SuspiciousOperation("non-integer passed for 'grade_id'")
    else:
        prev_grade_id = None
    if not pctx.has_permission(pperm.view_gradebook):
        raise PermissionDenied(_("may not view grade book"))
    assert pctx.request.user.is_authenticated
Andreas Klöckner's avatar
Andreas Klöckner committed

    flow_session = get_object_or_404(FlowSession, id=int(flow_session_id))

    if flow_session.course.pk != pctx.course.pk:
        raise SuspiciousOperation(
                _("Flow session not part of specified course"))
    if flow_session.participation is None:
        raise SuspiciousOperation(
                _("Cannot grade anonymous session"))
    from course.flow import adjust_flow_session_page_data
    adjust_flow_session_page_data(pctx.repo, flow_session,
            pctx.course.identifier, respect_preview=False)

Andreas Klöckner's avatar
Andreas Klöckner committed
    fpctx = FlowPageContext(pctx.repo, pctx.course, flow_session.flow_id,
                            page_ordinal, participation=flow_session.participation,
                            flow_session=flow_session, request=pctx.request)
Andreas Klöckner's avatar
Andreas Klöckner committed

    if fpctx.page_desc is None:
        raise http.Http404()

Andreas Klöckner's avatar
Andreas Klöckner committed
    assert fpctx.page is not None
    assert fpctx.page_context is not None

    # {{{ enable flow session zapping

    all_flow_sessions = list(FlowSession.objects
            .filter(
                course=pctx.course,
                flow_id=flow_session.flow_id,
                participation__isnull=False,
                in_progress=flow_session.in_progress)
            .order_by(
                # Datatables will default to sorting the user list
                # by the first column, which happens to be the username.
                # Match that sorting.
                "participation__user__username",
                "start_time"))

    next_flow_session_id = None
    prev_flow_session_id = None
    for i, other_flow_session in enumerate(all_flow_sessions):
        if other_flow_session.pk == flow_session.pk:
            if i > 0:
                prev_flow_session_id = all_flow_sessions[i-1].id
            if i + 1 < len(all_flow_sessions):
                next_flow_session_id = all_flow_sessions[i+1].id

    # }}}

    prev_grades = get_prev_visit_grades(pctx.course_identifier, flow_session_id,
                                        page_ordinal)
Andreas Klöckner's avatar
Andreas Klöckner committed
    # {{{ reproduce student view

    form = None
    feedback = None
    answer_data = None
    page_expects_answer = fpctx.page.expects_answer()

    if page_expects_answer:
        if fpctx.prev_answer_visit is not None and prev_grade_id is None:
Andreas Klöckner's avatar
Andreas Klöckner committed
            answer_data = fpctx.prev_answer_visit.answer

            shown_grade = fpctx.prev_answer_visit.get_most_recent_grade()
            if shown_grade is not None:
                feedback = get_feedback_for_grade(shown_grade)
                grade_data = shown_grade.grade_data
Andreas Klöckner's avatar
Andreas Klöckner committed
            else:
                feedback = None
                grade_data = None

            if shown_grade is not None:
                prev_grade_id = shown_grade.id

        elif prev_grade_id is not None:
            try:
                shown_grade = prev_grades.filter(id=prev_grade_id).get()
            except ObjectDoesNotExist:
                raise http.Http404()

            feedback = get_feedback_for_grade(shown_grade)
            grade_data = shown_grade.grade_data
            answer_data = shown_grade.visit.answer
Andreas Klöckner's avatar
Andreas Klöckner committed
        else:
            feedback = None

        from course.page.base import PageBehavior
        page_behavior = PageBehavior(
                show_correctness=True,
                show_answer=False,
                may_change_answer=False)

        try:
            form = fpctx.page.make_form(
                    fpctx.page_context, fpctx.page_data.data,
                    answer_data, page_behavior)
        except InvalidPageData as e:
            messages.add_message(pctx.request, messages.ERROR,
                    _(
                        "The page data stored in the database was found "
                        "to be invalid for the page as given in the "
                        "course content. Likely the course content was "
                        "changed in an incompatible way (say, by adding "
                        "an option to a choice question) without changing "
                        "the question ID. The precise error encountered "
                        "was the following: ")+str(e))

            return render_course_page(pctx, "course/course-base.html", {})
Andreas Klöckner's avatar
Andreas Klöckner committed

    if form is not None:
        form_html = fpctx.page.form_to_html(
                pctx.request, fpctx.page_context, form, answer_data)
Andreas Klöckner's avatar
Andreas Klöckner committed
    else:
        form_html = None

    # }}}

    # {{{ grading form

    grading_form: StyledForm | None = None

            and fpctx.page.is_answer_gradable()
            and fpctx.prev_answer_visit is not None
            and not flow_session.in_progress
            and not viewing_prev_grade):
        request = pctx.request
        if pctx.request.method == "POST":
            if not pctx.has_permission(pperm.assign_grade):
                raise PermissionDenied(_("may not assign grades"))

            grading_form = fpctx.page.post_grading_form(
                    fpctx.page_context, fpctx.page_data, grade_data,
                    request.POST, request.FILES)
            if grading_form.is_valid():
                grade_data = fpctx.page.update_grade_data_from_grading_form_v2(
                        request,
                        fpctx.page_context, fpctx.page_data, grade_data,
                        grading_form, request.FILES)
                from course.utils import LanguageOverride
                with LanguageOverride(pctx.course):
                            fpctx.page_context, fpctx.page_data.data,

                if feedback is not None:
                    correctness = feedback.correctness
                else:
                    correctness = None

                feedback_json: dict[str, Any] | None = None
                bulk_feedback_json: dict[str, Any] | None = None
                if feedback is not None:
                    feedback_json, bulk_feedback_json = feedback.as_json()
                else:
                    feedback_json = bulk_feedback_json = None
                most_recent_grade = FlowPageVisitGrade(
                        visit=fpctx.prev_answer_visit,
                        grader=pctx.request.user,
                        graded_at_git_commit_sha=pctx.course_commit_sha.decode(),

                        grade_data=grade_data,

                        max_points=fpctx.page.max_points(fpctx.page_data),
                        correctness=correctness,
                        feedback=feedback_json)

                prev_grade_id = _save_grade(fpctx, flow_session, most_recent_grade,
                        bulk_feedback_json, now_datetime)
        else:
            grading_form = fpctx.page.make_grading_form(
                    fpctx.page_context, fpctx.page_data, grade_data)

    else:
        grading_form = None

    grading_form_html: str | None = None
    if grading_form is not None:
        from crispy_forms.layout import Submit
        grading_form.helper.form_class += " relate-grading-form"
        grading_form.helper.add_input(
                Submit(
ifaint's avatar
ifaint committed
                    "submit", _("Submit"),
                    css_class="relate-grading-save-button"))

        grading_form_html = fpctx.page.grading_form_to_html(
                pctx.request, fpctx.page_context, grading_form, grade_data)

    # }}}
    # {{{ compute points_awarded

    max_points = None
    points_awarded = None
            and fpctx.page.is_answer_gradable()):
        max_points = fpctx.page.max_points(fpctx.page_data)
        if feedback is not None and feedback.correctness is not None:
            points_awarded = max_points * feedback.correctness

    # }}}

    grading_rule = get_session_grading_rule(
Andreas Klöckner's avatar
Andreas Klöckner committed
            flow_session, fpctx.flow_desc, get_now_or_fake_time(pctx.request))
    if grading_rule.grade_identifier is not None:
        grading_opportunity: GradingOpportunity | None = \
                get_flow_grading_opportunity(
                        pctx.course, flow_session.flow_id, fpctx.flow_desc,
                        grading_rule.grade_identifier,
                        grading_rule.grade_aggregation_strategy)
Andreas Klöckner's avatar
Andreas Klöckner committed

    return render_course_page(
            pctx,
            "course/grade-flow-page.html",
            {
                "flow_identifier": fpctx.flow_id,
Andreas Klöckner's avatar
Andreas Klöckner committed
                "flow_session": flow_session,
                "flow_desc": fpctx.flow_desc,
                "page_ordinal": fpctx.page_ordinal,
Andreas Klöckner's avatar
Andreas Klöckner committed
                "page_data": fpctx.page_data,

                "body": fpctx.page.body(
                    fpctx.page_context, fpctx.page_data.data),
                "form": form,
                "form_html": form_html,
                "feedback": feedback,
                "max_points": max_points,
                "points_awarded": points_awarded,
                "shown_grade": shown_grade,
                "prev_grade_id": prev_grade_id,
                "expects_answer": page_expects_answer,
Andreas Klöckner's avatar
Andreas Klöckner committed

                "grading_opportunity": grading_opportunity,

                "prev_flow_session_id": prev_flow_session_id,
                "next_flow_session_id": next_flow_session_id,

                "grading_form": grading_form,
                "grading_form_html": grading_form_html,
                "correct_answer": fpctx.page.correct_answer(
                    fpctx.page_context, fpctx.page_data.data,
                    answer_data, grade_data),

@retry_transaction_decorator()
Andreas Klöckner's avatar
Andreas Klöckner committed
def _save_grade(
        fpctx: FlowPageContext,
        flow_session: FlowSession,
        most_recent_grade: FlowPageVisitGrade,
        bulk_feedback_json: Any,
        now_datetime: datetime.datetime,
        ) -> int:
    most_recent_grade.save()
    most_recent_grade_id = most_recent_grade.id

    update_bulk_feedback(
            fpctx.prev_answer_visit.page_data,
            most_recent_grade,
            bulk_feedback_json)

    grading_rule = get_session_grading_rule(
Andreas Klöckner's avatar
Andreas Klöckner committed
            flow_session, fpctx.flow_desc, now_datetime)

    from course.flow import grade_flow_session
    grade_flow_session(fpctx, flow_session, grading_rule)

    return most_recent_grade_id

# {{{ grader statistics

@course_view
def show_grader_statistics(pctx, flow_id):
    if not pctx.has_permission(pperm.view_grader_stats):
        raise PermissionDenied(_("may not view grader stats"))
    grades = (FlowPageVisitGrade.objects
            .filter(
                visit__flow_session__course=pctx.course,
                visit__flow_session__flow_id=flow_id,

                # There are just way too many autograder grades, which makes this
                # report super slow.
                grader__isnull=False)
            .order_by(
                "visit__id",
                "grade_time")
            .select_related("visit")
            .select_related("grader")
            .select_related("visit__page_data"))
    # tuples: (page_ordinal, id)
    pages = set()

    counts = {}
    grader_counts = {}
    page_counts = {}

    def commit_grade_info(grade):
        grader = grade.grader
        page = (grade.visit.page_data.page_ordinal,
                grade.visit.page_data.group_id + "/" + grade.visit.page_data.page_id)

        graders.add(grader)
        pages.add(page)

        key = (page, grade.grader)
        counts[key] = counts.get(key, 0) + 1

        grader_counts[grader] = grader_counts.get(grader, 0) + 1
        page_counts[page] = page_counts.get(page, 0) + 1

    last_grade = None

    for grade in grades.iterator():
        if last_grade is not None and last_grade.visit != grade.visit:
            commit_grade_info(last_grade)

        last_grade = grade

    if last_grade is not None:
        commit_grade_info(last_grade)

    graders = sorted(graders,
            key=lambda grader: grader.last_name if grader is not None else None)
    pages = sorted(pages)

    stats_table = [
            [
                counts.get((page, grader), 0)
                for grader in graders
                ]
            for page in pages
            ]
    page_counts = [
            page_counts.get(page, 0)
            for page in pages
            ]
    grader_counts = [
            grader_counts.get(grader, 0)
            for grader in graders
            ]

    return render_course_page(
            pctx,
            "course/grading-statistics.html",
            {
                "flow_id": flow_id,
                "pages": pages,
                "graders": graders,
Andreas Klöckner's avatar
Andreas Klöckner committed
                "pages_stats_counts":
                    list(zip(pages, stats_table, page_counts, strict=True)),
                "grader_counts": grader_counts,
            })

# }}}
Andreas Klöckner's avatar
Andreas Klöckner committed

# vim: foldmethod=marker