From 5b66f65df320bca2e9a782411bc1c47550a8d4a7 Mon Sep 17 00:00:00 2001
From: Yichao Yu <yyc1992@gmail.com>
Date: Sat, 17 May 2014 19:58:31 -0400
Subject: [PATCH] disable kwargs support of memoize by default, remove iteritem
 wrapper since it will be handled by 2to3

---
 pytools/__init__.py  | 65 ++++++++++++++++++++++++--------------------
 test/test_pytools.py |  2 +-
 2 files changed, 37 insertions(+), 30 deletions(-)

diff --git a/pytools/__init__.py b/pytools/__init__.py
index 4328b9e..9feae01 100644
--- a/pytools/__init__.py
+++ b/pytools/__init__.py
@@ -369,41 +369,48 @@ def single_valued(iterable, equality_pred=operator.eq):
 
 # {{{ memoization / attribute storage
 
-def _memoize(func, key, args, kwargs):
-    # by Michele Simionato
-    # http://www.phyast.pitt.edu/~micheles/python/
-
-    try:
-        return func._memoize_dic[key]
-    except AttributeError:
-        # _memoize_dic doesn't exist yet.
-
-        result = func(*args, **kwargs)
-        func._memoize_dic = {key: result}
-        return result
-    except KeyError:
-        result = func(*args, **kwargs)
-        func._memoize_dic[key] = result
-        return result
-
-try:
-    dict.iteritems
-    def _iteritem(d):
-        return d.iteritems()
-except AttributeError:
-    def _iteritem(d):
-        return d.items()
-
 def memoize(*args, **kwargs):
+    use_kw = bool(kwargs.pop('use_kwargs', False))
     key_func = kwargs.pop(
-        'key', lambda *a, **kw: (a, frozenset(_iteritem(kw))))
+        'key', ((lambda *a, **kw: (a, frozenset(kw.iteritems())))
+                if use_kw else None))
     if kwargs:
         raise TypeError(
             "memorize recived unexpected keyword arguments: %s"
             % ", ".join(kwargs.keys()))
-    @my_decorator
-    def _deco(func, *args, **kwargs):
-        return _memoize(func, key_func(*args, **kwargs), args, kwargs)
+    if key_func is not None:
+        @my_decorator
+        def _deco(func, *args, **kwargs):
+            # by Michele Simionato
+            # http://www.phyast.pitt.edu/~micheles/python/
+            key = key_func(*args, **kwargs)
+            try:
+                return func._memoize_dic[key]
+            except AttributeError:
+                # _memoize_dic doesn't exist yet.
+                result = func(*args, **kwargs)
+                func._memoize_dic = {key: result}
+                return result
+            except KeyError:
+                result = func(*args, **kwargs)
+                func._memoize_dic[key] = result
+                return result
+    else:
+        @my_decorator
+        def _deco(func, *args):
+            # by Michele Simionato
+            # http://www.phyast.pitt.edu/~micheles/python/
+            try:
+                return func._memoize_dic[args]
+            except AttributeError:
+                # _memoize_dic doesn't exist yet.
+                result = func(*args)
+                func._memoize_dic = {args: result}
+                return result
+            except KeyError:
+                result = func(*args)
+                func._memoize_dic[args] = result
+                return result
     if not args:
         return _deco
     if callable(args[0]) and len(args) == 1:
diff --git a/test/test_pytools.py b/test/test_pytools.py
index c6f8a72..059129e 100644
--- a/test/test_pytools.py
+++ b/test/test_pytools.py
@@ -95,7 +95,7 @@ def test_memoize():
     from pytools import memoize
     count = [0]
 
-    @memoize
+    @memoize(use_kwargs=True)
     def f(i, j=1):
         count[0] += 1
         return i + j
-- 
GitLab