From 7be47b9d2cd81340c4e2ae79fb24fa6dcea5b09a Mon Sep 17 00:00:00 2001
From: Andreas Kloeckner <inform@tiker.net>
Date: Thu, 5 Jan 2017 15:59:47 +0800
Subject: [PATCH] Fix scaling of center distance in >1D

---
 pytential/qbx/__init__.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/pytential/qbx/__init__.py b/pytential/qbx/__init__.py
index baa5a6ba..ad60bb22 100644
--- a/pytential/qbx/__init__.py
+++ b/pytential/qbx/__init__.py
@@ -326,7 +326,7 @@ class QBXLayerPotentialSource(LayerPotentialSource):
     @memoize_method
     def panel_sizes(self, last_dim_length="nsources"):
         assert last_dim_length in ("nsources", "ncenters", "npanels")
-        # To get the panel size this does the equivalent of ∫ 1 ds.
+        # To get the panel size this does the equivalent of (∫ 1 ds)**(1/dim).
         # FIXME: Kernel optimizations
 
         discr = self.density_discr
@@ -334,7 +334,7 @@ class QBXLayerPotentialSource(LayerPotentialSource):
         if last_dim_length == "nsources" or last_dim_length == "ncenters":
             knl = lp.make_kernel(
                 "{[i,j,k]: 0<=i<nelements and 0<=j,k<nunit_nodes}",
-                "panel_sizes[i,j] = sum(k, ds[i,k])",
+                "panel_sizes[i,j] = sum(k, ds[i,k])**(1/dim)",
                 name="compute_size")
 
             def panel_size_view(discr, group_nr):
@@ -343,7 +343,7 @@ class QBXLayerPotentialSource(LayerPotentialSource):
         elif last_dim_length == "npanels":
             knl = lp.make_kernel(
                 "{[i,j]: 0<=i<nelements and 0<=j<nunit_nodes}",
-                "panel_sizes[i] = sum(j, ds[i,j])",
+                "panel_sizes[i] = sum(j, ds[i,j])**(1/dim)",
                 name="compute_size")
             from functools import partial
 
@@ -353,6 +353,8 @@ class QBXLayerPotentialSource(LayerPotentialSource):
         else:
             raise ValueError("unknown dim length specified")
 
+        knl = lp.fix_parameters(knl, dim=self.dim)
+
         with cl.CommandQueue(self.cl_context) as queue:
             from pytential import bind, sym
             ds = bind(
-- 
GitLab