From 43d6b9497f11e55f2fc6bc05a359061dcbc175fa Mon Sep 17 00:00:00 2001
From: Alexandru Fikl <alexfikl@gmail.com>
Date: Wed, 19 Feb 2025 09:58:37 +0200
Subject: [PATCH] fix(tests): add codes to all noqa comments

---
 test/gnuma_loopy_transforms.py      |  4 ++--
 test/test_apps.py                   |  6 +++---
 test/test_c_execution.py            |  2 +-
 test/test_dg.py                     | 27 +++++++++++++++------------
 test/test_from_loopy_import_star.py |  2 +-
 test/test_fusion.py                 |  4 ++--
 test/test_linalg.py                 | 14 ++++++--------
 test/test_loopy.py                  |  4 +---
 test/test_misc.py                   |  2 +-
 test/test_numa_diff.py              |  3 +--
 test/test_sem_reagan.py             | 14 +++++++++-----
 test/test_split_iname_slabs.py      | 12 +++++++++---
 test/test_statistics.py             |  8 +++++---
 test/test_target.py                 |  7 ++++---
 14 files changed, 60 insertions(+), 49 deletions(-)

diff --git a/test/gnuma_loopy_transforms.py b/test/gnuma_loopy_transforms.py
index 1b8842a66..afffb6724 100644
--- a/test/gnuma_loopy_transforms.py
+++ b/test/gnuma_loopy_transforms.py
@@ -14,7 +14,7 @@ def pick_apart_float_cast(value):
     return float(fval_match.group(2))
 
 
-def fix_euler_parameters(kernel, p_p0, p_Gamma, p_R):  # noqa
+def fix_euler_parameters(kernel, p_p0, p_Gamma, p_R):  # noqa: N803
     return lp.fix_parameters(
         kernel,
         p_p0=pick_apart_float_cast(p_p0),
@@ -36,7 +36,7 @@ def set_D_storage_format(kernel):  # noqa: N802
     return lp.tag_array_axes(kernel, "D", "f,f")
 
 
-def set_up_volume_loop(kernel, Nq):  # noqa
+def set_up_volume_loop(kernel, Nq):  # noqa: N803
     kernel = lp.fix_parameters(kernel, Nq=Nq)
     kernel = lp.prioritize_loops(kernel, "e,k,j,i")
     kernel = lp.tag_inames(kernel, {"e": "g.0", "j": "l.1", "i": "l.0"})
diff --git a/test/test_apps.py b/test/test_apps.py
index 8c32aa9ac..862b39463 100644
--- a/test/test_apps.py
+++ b/test/test_apps.py
@@ -450,7 +450,7 @@ def test_lbm(ctx_factory):
     # Example by Loic Gouarin <loic.gouarin@math.u-psud.fr>
     knl = lp.make_kernel(
         "{[ii,jj]:0<=ii<nx-2 and 0<=jj<ny-2}",
-        """  # noqa (silences flake8 line length warning)
+        """
         i := ii + 1
         j := jj + 1
         for ii, jj
@@ -621,7 +621,7 @@ def test_poisson_fem(ctx_factory):
 def test_domain_tree_nesting():
     # From https://github.com/inducer/loopy/issues/78
 
-    AS = lp.AddressSpace        # noqa
+    AS = lp.AddressSpace        # noqa: N806
 
     out_map = np.array([1, 2], dtype=np.int32)
     if_val = np.array([-1, 0], dtype=np.int32)
@@ -629,7 +629,7 @@ def test_domain_tree_nesting():
     num_vals = np.array([2, 4], dtype=np.int32)
     num_vals_offset = np.array(np.cumsum(num_vals) - num_vals, dtype=np.int32)
 
-    TV = lp.TemporaryVariable  # noqa
+    TV = lp.TemporaryVariable  # noqa: N806
 
     knl = lp.make_kernel(["{[i]: 0 <= i < 12}",
                     "{[j]: 0 <= j < 100}",
diff --git a/test/test_c_execution.py b/test/test_c_execution.py
index 33e50e3ab..699c8f16a 100644
--- a/test/test_c_execution.py
+++ b/test/test_c_execution.py
@@ -280,7 +280,7 @@ def test_c_execution_with_global_temporaries():
     # global constant temporaries is None
 
     from loopy.target.c import ExecutableCTarget
-    AS = lp.AddressSpace        # noqa
+    AS = lp.AddressSpace        # noqa: N806
     n = 10
 
     knl = lp.make_kernel("{[i]: 0 <= i < n}",
diff --git a/test/test_dg.py b/test/test_dg.py
index e19507260..47d02a611 100644
--- a/test/test_dg.py
+++ b/test/test_dg.py
@@ -20,18 +20,21 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 """
 
-
-import logging  # noqa
+import logging
 
 import numpy as np
+
 import pyopencl as cl
 import pyopencl.array
-from pyopencl.tools import (  # noqa
+from pyopencl.tools import (  # noqa: F401
     pytest_generate_tests_for_pyopencl as pytest_generate_tests,
 )
 
 import loopy as lp
-from loopy.version import LOOPY_USE_LANGUAGE_VERSION_2018_2  # noqa
+from loopy.version import LOOPY_USE_LANGUAGE_VERSION_2018_2  # noqa: F401
+
+
+logger = logging.getLogger(__name__)
 
 
 def test_dg_volume(ctx_factory):
@@ -43,10 +46,10 @@ def test_dg_volume(ctx_factory):
 
     order = "F"
 
-    N = 3  # noqa
-    Np = (N+1)*(N+2)*(N+3)//6  # noqa
+    N = 3  # noqa: N806
+    Np = (N+1)*(N+2)*(N+3)//6  # noqa: N806
 
-    K = 10000  # noqa
+    K = 10000  # noqa: N806
 
     knl = lp.make_kernel([
             "{[n,m,k]: 0<= n,m < Np and 0<= k < K}",
@@ -178,12 +181,12 @@ def no_test_dg_surface(ctx_factory):
 
     order = "F"
 
-    N = 3  # noqa
-    Np = (N+1)*(N+2)*(N+3)//6  # noqa
-    Nfp = (N+1)*(N+2)//2  # noqa
-    Nfaces = 4  # noqa
+    N = 3  # noqa: N806
+    Np = (N+1)*(N+2)*(N+3)//6  # noqa: N806
+    Nfp = (N+1)*(N+2)//2  # noqa: N806
+    Nfaces = 4  # noqa: N806
 
-    K = 10000  # noqa
+    K = 10000  # noqa: N806
 
     knl = lp.make_kernel(
             [
diff --git a/test/test_from_loopy_import_star.py b/test/test_from_loopy_import_star.py
index 4f339ef96..4ae83a3f7 100644
--- a/test/test_from_loopy_import_star.py
+++ b/test/test_from_loopy_import_star.py
@@ -1 +1 @@
-from loopy import *  # noqa
+from loopy import *  # noqa: F403
diff --git a/test/test_fusion.py b/test/test_fusion.py
index 715de89c5..26ae7ff33 100644
--- a/test/test_fusion.py
+++ b/test/test_fusion.py
@@ -24,8 +24,8 @@ THE SOFTWARE.
 import numpy as np
 
 import pyopencl as cl
-from pyopencl.tools import (
-    pytest_generate_tests_for_pyopencl as pytest_generate_tests,  # noqa
+from pyopencl.tools import (  # noqa: F401
+    pytest_generate_tests_for_pyopencl as pytest_generate_tests,
 )
 
 import loopy as lp
diff --git a/test/test_linalg.py b/test/test_linalg.py
index ebd2e96bd..b09b3fb62 100644
--- a/test/test_linalg.py
+++ b/test/test_linalg.py
@@ -28,13 +28,14 @@ import numpy as np
 import pytest
 
 import pyopencl as cl
-import pyopencl.array as cl_array  # noqa: F401
-import pyopencl.cltypes as cltypes
-from pyopencl.tools import (  # noqa
+import pyopencl.array
+import pyopencl.cltypes
+from pyopencl.tools import (  # noqa: F401
     pytest_generate_tests_for_pyopencl as pytest_generate_tests,
 )
 
 import loopy as lp
+from loopy.version import LOOPY_USE_LANGUAGE_VERSION_2018_2  # noqa: F401
 
 
 DEBUG_PREAMBLE = r"""
@@ -62,9 +63,6 @@ def check_float4(result, ref_result):
                 ref_result[comp], result[comp], rtol=1e-3, atol=1e-3), None
 
 
-from loopy.version import LOOPY_USE_LANGUAGE_VERSION_2018_2  # noqa
-
-
 def test_axpy(ctx_factory):
     logging.basicConfig(level="INFO")
     ctx = ctx_factory()
@@ -653,8 +651,8 @@ def test_small_batched_matvec(ctx_factory):
 
     order = "C"
 
-    K = 9997  # noqa
-    Np = 36  # noqa
+    K = 9997  # noqa: N806
+    Np = 36  # noqa: N806
 
     knl = lp.make_kernel(
             "{[i,j,k]: 0<=k<K and 0<= i,j < %d}" % Np,
diff --git a/test/test_loopy.py b/test/test_loopy.py
index 834400341..4983d8df4 100644
--- a/test/test_loopy.py
+++ b/test/test_loopy.py
@@ -85,8 +85,6 @@ def test_globals_decl_once_with_multi_subprogram(ctx_factory):
 
 
 def test_complicated_subst(ctx_factory):
-    # ctx = ctx_factory()
-
     knl = lp.make_kernel(
             "{[i]: 0<=i<n}",
             """
@@ -2199,7 +2197,7 @@ def test_nosync_option_parsing():
     assert "id=insn1, no_sync_with=insn1@any" in kernel_str
     assert "id=insn2, no_sync_with=insn1@any:insn2@any" in kernel_str
     assert "id=insn3, no_sync_with=insn1@local:insn2@global:insn3@any" in kernel_str
-    assert "id=insn4, no_sync_with=insn1@local:insn2@local:insn3@local:insn5@local" in kernel_str  # noqa
+    assert "id=insn4, no_sync_with=insn1@local:insn2@local:insn3@local:insn5@local" in kernel_str  # noqa: E501
     assert "id=insn5, no_sync_with=insn1@any" in kernel_str
 
 
diff --git a/test/test_misc.py b/test/test_misc.py
index cee8431c3..184b720b6 100644
--- a/test/test_misc.py
+++ b/test/test_misc.py
@@ -249,7 +249,7 @@ def test_lazily_unpickling_list_eq_and_persistent_hashing():
     # }}}
 
 
-def test_Optional():  # noqa
+def test_optional():
     from loopy import Optional
 
     # {{{ test API
diff --git a/test/test_numa_diff.py b/test/test_numa_diff.py
index 92020b73a..0bc598182 100644
--- a/test/test_numa_diff.py
+++ b/test/test_numa_diff.py
@@ -1,6 +1,5 @@
 """gNUMA differentiation kernel, wrapped up as a test."""
 
-
 __copyright__ = "Copyright (C) 2015 Andreas Kloeckner, Lucas Wilcox"
 
 __license__ = """
@@ -51,7 +50,7 @@ from loopy.version import LOOPY_USE_LANGUAGE_VERSION_2018_2  # noqa
 @pytest.mark.parametrize("ilp_multiple", [1, 2])
 @pytest.mark.parametrize("Nq", [7])
 @pytest.mark.parametrize("opt_level", [11])
-def test_gnuma_horiz_kernel(ctx_factory, ilp_multiple, Nq, opt_level):  # noqa
+def test_gnuma_horiz_kernel(ctx_factory, ilp_multiple, Nq, opt_level):  # noqa: N803
     pytest.importorskip("fparser")
     ctx = ctx_factory()
 
diff --git a/test/test_sem_reagan.py b/test/test_sem_reagan.py
index 7969795bf..602549a68 100644
--- a/test/test_sem_reagan.py
+++ b/test/test_sem_reagan.py
@@ -20,16 +20,20 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 """
 
+import logging
 
 import numpy as np
 
-import pyopencl as cl  # noqa
-from pyopencl.tools import (  # noqa
+import pyopencl as cl  # noqa: F401
+from pyopencl.tools import (  # noqa: F401
     pytest_generate_tests_for_pyopencl as pytest_generate_tests,
 )
 
 import loopy as lp
-from loopy.version import LOOPY_USE_LANGUAGE_VERSION_2018_2  # noqa
+from loopy.version import LOOPY_USE_LANGUAGE_VERSION_2018_2  # noqa: F401
+
+
+logger = logging.getLogger(__name__)
 
 
 def test_tim2d(ctx_factory):
@@ -40,7 +44,7 @@ def test_tim2d(ctx_factory):
     n = 8
 
     from pymbolic import var
-    K_sym = var("K")  # noqa
+    K_sym = var("K")  # noqa: N806
 
     field_shape = (K_sym, n, n)
 
@@ -103,7 +107,7 @@ def test_tim2d(ctx_factory):
         return knl
 
     for variant in [variant_orig]:
-        K = 1000  # noqa
+        K = 1000  # noqa: N806
         lp.auto_test_vs_ref(seq_knl, ctx, variant(knl),
                 op_count=[K*(n*n*n*2*2 + n*n*2*3 + n**3 * 2*2)/1e9],
                 op_label=["GFlops"],
diff --git a/test/test_split_iname_slabs.py b/test/test_split_iname_slabs.py
index 4b9e74af5..e9f0370ca 100644
--- a/test/test_split_iname_slabs.py
+++ b/test/test_split_iname_slabs.py
@@ -19,17 +19,23 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 """
+
+import logging
+
 import numpy as np
 import pytest
 
 import pyopencl as cl
 import pyopencl.array as clarray
-from pyopencl.tools import (
-    pytest_generate_tests_for_pyopencl as pytest_generate_tests,  # noqa
+from pyopencl.tools import (  # noqa: F401
+    pytest_generate_tests_for_pyopencl as pytest_generate_tests,
 )
 
 import loopy as lp
-from loopy.version import LOOPY_USE_LANGUAGE_VERSION_2018_2  # noqa
+from loopy.version import LOOPY_USE_LANGUAGE_VERSION_2018_2  # noqa: F401
+
+
+logger = logging.getLogger(__name__)
 
 
 @pytest.fixture
diff --git a/test/test_statistics.py b/test/test_statistics.py
index afb657ea1..adaffcbec 100644
--- a/test/test_statistics.py
+++ b/test/test_statistics.py
@@ -20,12 +20,12 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 """
 
-import sys
+import logging
 
 import numpy as np
 
 from pymbolic.primitives import Variable
-from pyopencl.tools import (  # noqa
+from pyopencl.tools import (  # noqa: F401
     pytest_generate_tests_for_pyopencl as pytest_generate_tests,
 )
 from pytools import div_ceil
@@ -33,9 +33,11 @@ from pytools import div_ceil
 import loopy as lp
 from loopy.statistics import CountGranularity as CG
 from loopy.types import to_loopy_type
-from loopy.version import LOOPY_USE_LANGUAGE_VERSION_2018_2  # noqa
+from loopy.version import LOOPY_USE_LANGUAGE_VERSION_2018_2  # noqa: F401
 
 
+logger = logging.getLogger(__name__)
+
 SGS = 32  # Subgroup size
 
 
diff --git a/test/test_target.py b/test/test_target.py
index b4cb509de..b0cb5e73c 100644
--- a/test/test_target.py
+++ b/test/test_target.py
@@ -107,18 +107,19 @@ def test_cuda_target():
 
 def test_generate_c_snippet():
     from pymbolic import var
-    I = var("I")  # noqa
+
+    I = var("I")  # noqa: N806,E741
     f = var("f")
     df = var("df")
     q_v = var("q_v")
-    eN = var("eN")  # noqa
     k = var("k")
     u = var("u")
 
     from functools import partial
+
     l_sum = partial(lp.Reduction, "sum", allow_simultaneous=True)
 
-    Instr = lp.Assignment  # noqa
+    Instr = lp.Assignment  # noqa: N806
 
     knl = lp.make_kernel(
         "{[I, k]: 0<=I<nSpace and 0<=k<nQuad}",
-- 
GitLab