From 3f5585ea911f9dbae354a275eb7fbce8a4ea4c09 Mon Sep 17 00:00:00 2001 From: Andreas Kloeckner Date: Wed, 25 Oct 2017 16:58:58 +0200 Subject: [PATCH] Placate flake8 re: usage of ell --- test/test_fortran.py | 22 ++-- test/test_linalg.py | 8 +- test/test_reduction.py | 10 +- test/test_statistics.py | 231 ++++++++++++++++++++-------------------- 4 files changed, 138 insertions(+), 133 deletions(-) diff --git a/test/test_fortran.py b/test/test_fortran.py index 6e05aa6ad..aa5a7e6e2 100644 --- a/test/test_fortran.py +++ b/test/test_fortran.py @@ -278,14 +278,14 @@ def test_matmul(ctx_factory, buffer_inames): logging.basicConfig(level=logging.INFO) fortran_src = """ - subroutine dgemm(m,n,l,a,b,c) + subroutine dgemm(m,n,ell,a,b,c) implicit none - real*8 a(m,l),b(l,n),c(m,n) - integer m,n,k,i,j,l + real*8 a(m,ell),b(l,n),c(m,n) + integer m,n,k,i,j,ell do j = 1,n do i = 1,m - do k = 1,l + do k = 1,ell c(i,j) = c(i,j) + b(k,j)*a(i,k) end do end do @@ -317,7 +317,7 @@ def test_matmul(ctx_factory, buffer_inames): init_expression="0", store_expression="base+buffer") ctx = ctx_factory() - lp.auto_test_vs_ref(ref_knl, ctx, knl, parameters=dict(n=128, m=128, l=128)) + lp.auto_test_vs_ref(ref_knl, ctx, knl, parameters=dict(n=128, m=128, ell=128)) @pytest.mark.xfail @@ -457,14 +457,14 @@ def test_parse_and_fuse_two_kernels(): def test_precompute_some_exist(ctx_factory): fortran_src = """ - subroutine dgemm(m,n,l,a,b,c) + subroutine dgemm(m,n,ell,a,b,c) implicit none - real*8 a(m,l),b(l,n),c(m,n) - integer m,n,k,i,j,l + real*8 a(m,ell),b(,n),c(m,n) + integer m,n,k,i,j,ell do j = 1,n do i = 1,m - do k = 1,l + do k = 1,ell c(i,j) = c(i,j) + b(k,j)*a(i,k) end do end do @@ -483,7 +483,7 @@ def test_precompute_some_exist(ctx_factory): knl = lp.split_iname(knl, "k", 8) knl = lp.assume(knl, "n mod 8 = 0") knl = lp.assume(knl, "m mod 8 = 0") - knl = lp.assume(knl, "l mod 8 = 0") + knl = lp.assume(knl, "ell mod 8 = 0") knl = lp.extract_subst(knl, "a_acc", "a[i1,i2]", parameters="i1, i2") knl = lp.extract_subst(knl, "b_acc", "b[i1,i2]", parameters="i1, i2") @@ -495,7 +495,7 @@ def test_precompute_some_exist(ctx_factory): ref_knl = knl ctx = ctx_factory() - lp.auto_test_vs_ref(ref_knl, ctx, knl, parameters=dict(n=128, m=128, l=128)) + lp.auto_test_vs_ref(ref_knl, ctx, knl, parameters=dict(n=128, m=128, ell=128)) if __name__ == "__main__": diff --git a/test/test_linalg.py b/test/test_linalg.py index 772d536d1..3d422f1d8 100644 --- a/test/test_linalg.py +++ b/test/test_linalg.py @@ -230,14 +230,14 @@ def test_funny_shape_matrix_mul(ctx_factory): n = get_suitable_size(ctx) m = n+12 - l = m+12 + ell = m+12 knl = lp.make_kernel( - "{[i,k,j]: 0<=i sumlen = l[i]", + "<> sumlen = ell[i]", "a[i] = sum(j, j)", ], [ lp.ValueArg("n", np.int32), lp.GlobalArg("a", dtype, ("n",)), - lp.GlobalArg("l", np.int32, ("n",)), + lp.GlobalArg("ell", np.int32, ("n",)), ]) cknl = lp.CompiledKernel(ctx, knl) n = 330 - l = np.arange(n, dtype=np.int32) - evt, (a,) = cknl(queue, l=l, n=n, out_host=True) + ell = np.arange(n, dtype=np.int32) + evt, (a,) = cknl(queue, ell=ell, n=n, out_host=True) - tgt_result = (2*l-1)*2*l/2 + tgt_result = (2*ell-1)*2*ell/2 assert (a == tgt_result).all() diff --git a/test/test_statistics.py b/test/test_statistics.py index cf86539ef..3b33a8eff 100644 --- a/test/test_statistics.py +++ b/test/test_statistics.py @@ -37,14 +37,14 @@ from pymbolic.primitives import Variable def test_op_counter_basic(): knl = lp.make_kernel( - "[n,m,l] -> {[i,k,j]: 0<=i {[i,k,j]: 0<=i6 or k/2==l, g[i,k]*2, g[i,k]+h[i,k]/2) + e[i,k] = if( + not(k6 or k/2==ell, + g[i,k]*2, + g[i,k]+h[i,k]/2) """ ], - name="logic", assumptions="n,m,l >= 1") + name="logic", assumptions="n,m,ell >= 1") knl = lp.add_and_infer_dtypes(knl, dict(g=np.float32, h=np.float64)) op_map = lp.get_op_map(knl, count_redundant_work=True) n = 512 m = 256 - l = 128 - params = {'n': n, 'm': m, 'l': l} + ell = 128 + params = {'n': n, 'm': m, 'ell': ell} f32mul = op_map[lp.Op(np.float32, 'mul')].eval_with_dict(params) f64add = op_map[lp.Op(np.float64, 'add')].eval_with_dict(params) f64div = op_map[lp.Op(np.dtype(np.float64), 'div')].eval_with_dict(params) @@ -118,14 +121,14 @@ def test_op_counter_logic(): def test_op_counter_specialops(): knl = lp.make_kernel( - "{[i,k,j]: 0<=i> k)) """ ], - name="bitwise", assumptions="n,m,l >= 1") + name="bitwise", assumptions="n,m,ell >= 1") knl = lp.add_and_infer_dtypes( knl, dict( @@ -169,16 +172,16 @@ def test_op_counter_bitwise(): op_map = lp.get_op_map(knl, count_redundant_work=True) n = 512 m = 256 - l = 128 - params = {'n': n, 'm': m, 'l': l} + ell = 128 + params = {'n': n, 'm': m, 'ell': ell} i32add = op_map[lp.Op(np.int32, 'add')].eval_with_dict(params) i32bw = op_map[lp.Op(np.int32, 'bw')].eval_with_dict(params) i64bw = op_map[lp.Op(np.dtype(np.int64), 'bw')].eval_with_dict(params) i64mul = op_map[lp.Op(np.dtype(np.int64), 'mul')].eval_with_dict(params) i64add = op_map[lp.Op(np.dtype(np.int64), 'add')].eval_with_dict(params) i64shift = op_map[lp.Op(np.dtype(np.int64), 'shift')].eval_with_dict(params) - assert i32add == n*m+n*m*l - assert i32bw == 2*n*m*l + assert i32add == n*m+n*m*ell + assert i32bw == 2*n*m*ell assert i64bw == 2*n*m assert i64add == i64mul == n*m assert i64shift == 2*n*m @@ -218,22 +221,22 @@ def test_op_counter_triangular_domain(): def test_mem_access_counter_basic(): knl = lp.make_kernel( - "[n,m,l] -> {[i,k,j]: 0<=i {[i,k,j]: 0<=i6 or k/2==l, g[i,k]*2, g[i,k]+h[i,k]/2) + e[i,k] = if(not(k6 or k/2==ell, + g[i,k]*2, + g[i,k]+h[i,k]/2) """ ], - name="logic", assumptions="n,m,l >= 1") + name="logic", assumptions="n,m,ell >= 1") knl = lp.add_and_infer_dtypes(knl, dict(g=np.float32, h=np.float64)) mem_map = lp.get_mem_access_map(knl, count_redundant_work=True) n = 512 m = 256 - l = 128 - params = {'n': n, 'm': m, 'l': l} + ell = 128 + params = {'n': n, 'm': m, 'ell': ell} reduced_map = mem_map.group_by('mtype', 'dtype', 'direction') @@ -332,22 +337,22 @@ def test_mem_access_counter_logic(): def test_mem_access_counter_specialops(): knl = lp.make_kernel( - "{[i,k,j]: 0<=i> k)) """ ], - name="bitwise", assumptions="n,m,l >= 1") + name="bitwise", assumptions="n,m,ell >= 1") knl = lp.add_and_infer_dtypes( knl, dict( @@ -398,8 +403,8 @@ def test_mem_access_counter_bitwise(): mem_map = lp.get_mem_access_map(knl, count_redundant_work=True) n = 512 m = 256 - l = 128 - params = {'n': n, 'm': m, 'l': l} + ell = 128 + params = {'n': n, 'm': m, 'ell': ell} i32 = mem_map[lp.MemAccess('global', np.int32, stride=0, direction='load', variable='a') ].eval_with_dict(params) @@ -412,7 +417,7 @@ def test_mem_access_counter_bitwise(): i32 += mem_map[lp.MemAccess('global', np.dtype(np.int32), stride=0, direction='load', variable='h') ].eval_with_dict(params) - assert i32 == 4*n*m+2*n*m*l + assert i32 == 4*n*m+2*n*m*ell i32 = mem_map[lp.MemAccess('global', np.int32, stride=0, direction='store', variable='c') @@ -420,20 +425,20 @@ def test_mem_access_counter_bitwise(): i32 += mem_map[lp.MemAccess('global', np.int32, stride=0, direction='store', variable='e') ].eval_with_dict(params) - assert i32 == n*m+n*m*l + assert i32 == n*m+n*m*ell def test_mem_access_counter_mixed(): knl = lp.make_kernel( - "[n,m,l] -> {[i,k,j]: 0<=i {[i,k,j]: 0<=i {[i,k,j]: 0<=i {[i,k,j]: 0<=i {[i,k,j]: 0<=i {[i,k,j]: 0<=i {[i,k,j]: 0<=i {[i,k,j]: 0<=i {[i,k,j]: 0<=i<50 and 1<=k<98 and 0<=j<10}", + "[n,m,ell] -> {[i,k,j]: 0<=i<50 and 1<=k<98 and 0<=j<10}", [ """ c[i,j,k] = 2*a[i,j,k] {id=first} @@ -620,8 +625,8 @@ def test_barrier_counter_barriers(): print(sync_map) n = 512 m = 256 - l = 128 - params = {'n': n, 'm': m, 'l': l} + ell = 128 + params = {'n': n, 'm': m, 'ell': ell} barrier_count = sync_map["barrier_local"].eval_with_dict(params) assert barrier_count == 50*10*2 @@ -630,13 +635,13 @@ def test_all_counters_parallel_matmul(): bsize = 16 knl = lp.make_kernel( - "{[i,k,j]: 0<=i {[i,k,j]: 0<=i {[i,k,j]: 0<=i