From d778430473a03d93f750e6010a614e9c140d94f7 Mon Sep 17 00:00:00 2001
From: Thomas Gibson <gibsonthomas1120@hotmail.com>
Date: Mon, 3 May 2021 16:13:47 -0500
Subject: [PATCH] Raise error if discretization tag is unknown
---
grudge/dof_desc.py | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/grudge/dof_desc.py b/grudge/dof_desc.py
index 9281769d..aeb3daec 100644
--- a/grudge/dof_desc.py
+++ b/grudge/dof_desc.py
@@ -272,11 +272,17 @@ class DOFDesc:
# This can go away once support for strings is dropped
# completely.
if isinstance(self.discretization_tag, str):
+ # All strings are interpreted as quadrature-related tags
return True
- if issubclass(self.discretization_tag, DISCR_TAG_QUAD):
+ elif issubclass(self.discretization_tag, DISCR_TAG_QUAD):
return True
-
- return False
+ elif issubclass(self.discretization_tag,
+ (DISCR_TAG_BASE, DISCR_TAG_MODAL)):
+ return False
+ else:
+ raise ValueError(
+ f"Unsure how to interpret tag: {self.discretization_tag}"
+ )
def with_qtag(self, discr_tag):
warn("`DOFDesc.with_qtag` is deprecated and will be dropped "
--
GitLab