From 51e3b51c8813248ad5d9e362917ddba3da6bf6f8 Mon Sep 17 00:00:00 2001
From: Andreas Kloeckner <inform@tiker.net>
Date: Mon, 17 Aug 2020 11:45:04 -0500
Subject: [PATCH] Fix, test 2-norm computation: do not take absolute values
---
grudge/symbolic/operators.py | 2 +-
test/test_grudge.py | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/grudge/symbolic/operators.py b/grudge/symbolic/operators.py
index b95575f6..4ecd920c 100644
--- a/grudge/symbolic/operators.py
+++ b/grudge/symbolic/operators.py
@@ -721,7 +721,7 @@ def norm(p, arg, dd=None):
if p == 2:
norm_squared = NodalSum(dd_in=dd)(
- prim.fabs(arg * MassOperator()(arg)))
+ arg * MassOperator()(arg))
if isinstance(norm_squared, np.ndarray):
if len(norm_squared.shape) != 1:
diff --git a/test/test_grudge.py b/test/test_grudge.py
index 60f58ddf..b3662b5f 100644
--- a/test/test_grudge.py
+++ b/test/test_grudge.py
@@ -669,7 +669,7 @@ def test_norm_obj_array(ctx_factory, p):
norm_exact = w[0]
logger.info("norm: %.5e %.5e", norm, norm_exact)
- # assert abs(norm - norm_exact) < 1.0e-14
+ assert abs(norm - norm_exact) < 1.0e-14
# }}}
@@ -680,7 +680,7 @@ def test_norm_obj_array(ctx_factory, p):
norm_exact = np.sqrt(np.sum(w**2)) if p == 2 else np.max(w)
logger.info("norm: %.5e %.5e", norm, norm_exact)
- # assert abs(norm - norm_exact) < 1.0e-14
+ assert abs(norm - norm_exact) < 1.0e-14
# }}}
--
GitLab