From ec7b24038c808e410cb4af945747822adf69c9bd Mon Sep 17 00:00:00 2001 From: Matt Wala Date: Thu, 11 Jun 2020 23:20:43 -0500 Subject: [PATCH] Update comment concerning pip in-place build issue --- build-py-project-within-miniconda.sh | 2 +- build-py-project.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build-py-project-within-miniconda.sh b/build-py-project-within-miniconda.sh index 25e8ae6..7fcb33a 100644 --- a/build-py-project-within-miniconda.sh +++ b/build-py-project-within-miniconda.sh @@ -17,7 +17,7 @@ echo "-----------------------------------------------" # Append --editable to PROJECT_INSTALL_FLAGS, if not there already. # See: https://gitlab.tiker.net/inducer/ci-support/-/issues/3 -# Can be removed after pip 20.1 is released. +# Can be removed after https://github.com/pypa/pip/issues/2195 is resolved. if [[ ! $PROJECT_INSTALL_FLAGS =~ (^|[[:space:]]*)(--editable|-e)[[:space:]]*$ ]]; then PROJECT_INSTALL_FLAGS="$PROJECT_INSTALL_FLAGS --editable" fi diff --git a/build-py-project.sh b/build-py-project.sh index fa6ced9..0870c29 100644 --- a/build-py-project.sh +++ b/build-py-project.sh @@ -15,7 +15,7 @@ echo "-----------------------------------------------" # Append --editable to PROJECT_INSTALL_FLAGS, if not there already. # See: https://gitlab.tiker.net/inducer/ci-support/-/issues/3 -# Can be removed after pip 20.1 is released. +# Can be removed after https://github.com/pypa/pip/issues/2195 is resolved. if [[ ! $PROJECT_INSTALL_FLAGS =~ (^|[[:space:]]*)(--editable|-e)[[:space:]]*$ ]]; then PROJECT_INSTALL_FLAGS="$PROJECT_INSTALL_FLAGS --editable" fi -- GitLab