From 9682d885e18efc11b999f82b96b5f8d03382375d Mon Sep 17 00:00:00 2001 From: Isuru Fernando Date: Sat, 29 Jun 2019 00:28:51 -0500 Subject: [PATCH 1/2] Use spawn launch method in asv In default method asv will close stdin and new pytools looks at stdin to determine if the session is interactive. Solution found in https://github.com/pandas-dev/pandas/pull/25237 --- build-and-benchmark-py-project.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build-and-benchmark-py-project.sh b/build-and-benchmark-py-project.sh index a097788..801f84f 100644 --- a/build-and-benchmark-py-project.sh +++ b/build-and-benchmark-py-project.sh @@ -37,8 +37,8 @@ fi master_commit=`git rev-parse master` test_commit=`git rev-parse HEAD` -asv run $master_commit...$master_commit~ --skip-existing --verbose --show-stderr -asv run $test_commit...$test_commit~ --skip-existing --verbose --show-stderr +asv run $master_commit...$master_commit~ --skip-existing --verbose --show-stderr --launch-method=spawn +asv run $test_commit...$test_commit~ --skip-existing --verbose --show-stderr --launch-method=spawn output=`asv compare $master_commit $test_commit --factor 1 -s` echo "$output" -- GitLab From 15abb6d7336d05ca7b2f7cace5f6cabb91c2156d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20Kl=C3=B6ckner?= Date: Sat, 29 Jun 2019 09:29:44 +0200 Subject: [PATCH 2/2] Add comment to preserve link on asv --launch-method=spawn --- build-and-benchmark-py-project.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/build-and-benchmark-py-project.sh b/build-and-benchmark-py-project.sh index 801f84f..faa5784 100644 --- a/build-and-benchmark-py-project.sh +++ b/build-and-benchmark-py-project.sh @@ -37,6 +37,8 @@ fi master_commit=`git rev-parse master` test_commit=`git rev-parse HEAD` +# cf. https://github.com/pandas-dev/pandas/pull/25237 +# for reasoning on --launch-method=spawn asv run $master_commit...$master_commit~ --skip-existing --verbose --show-stderr --launch-method=spawn asv run $test_commit...$test_commit~ --skip-existing --verbose --show-stderr --launch-method=spawn -- GitLab