Commit d6a0fe70 authored by Matt Wala's avatar Matt Wala
Browse files

Run Pylint in "errors only" mode 

This changes .pylintrc-default to use the configuration for errors
only mode. This results in fewer (and more significant) messages from
Pylint.

I think these messages are likely to be more useful than the current
configuration, and it will also be easier to adapt software to make
use of Pylint this way.
parent d86f594a

.pylintrc-default

+460 −214
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ limit-inference-results=100 
load-plugins=



# Pickle collected data for later comparisons.

persistent=yes

persistent=no



# Specify a configuration file.

#rcfile=
@@ -60,7 +60,41 @@ confidence= 
# --enable=similarities". If you want to run only the classes checker, but have

# no Warning level messages displayed, use "--disable=all --enable=classes

# --disable=W".

disable=print-statement,

disable=blacklisted-name,

        invalid-name,

        missing-docstring,

        empty-docstring,

        unneeded-not,

        singleton-comparison,

        misplaced-comparison-constant,

        unidiomatic-typecheck,

        consider-using-enumerate,

        consider-iterating-dictionary,

        bad-classmethod-argument,

        bad-mcs-method-argument,

        bad-mcs-classmethod-argument,

        single-string-used-for-slots,

        line-too-long,

        too-many-lines,

        trailing-whitespace,

        missing-final-newline,

        trailing-newlines,

        multiple-statements,

        superfluous-parens,

        bad-whitespace,

        mixed-line-endings,

        unexpected-line-ending-format,

        bad-continuation,

        wrong-spelling-in-comment,

        wrong-spelling-in-docstring,

        invalid-characters-in-docstring,

        multiple-imports,

        wrong-import-order,

        ungrouped-imports,

        wrong-import-position,

        useless-import-alias,

        len-as-condition,

        print-statement,

        parameter-unpacking,

        unpacking-in-except,

        old-raise-syntax,
@@ -73,12 +107,133 @@ disable=print-statement, 
        raw-checker-failed,

        bad-inline-option,

        locally-disabled,

        locally-enabled,

        file-ignored,

        suppressed-message,

        useless-suppression,

        deprecated-pragma,

        use-symbolic-message-instead,

        c-extension-no-member,

        literal-comparison,

        comparison-with-itself,

        no-self-use,

        no-classmethod-decorator,

        no-staticmethod-decorator,

        useless-object-inheritance,

        cyclic-import,

        duplicate-code,

        too-many-ancestors,

        too-many-instance-attributes,

        too-few-public-methods,

        too-many-public-methods,

        too-many-return-statements,

        too-many-branches,

        too-many-arguments,

        too-many-locals,

        too-many-statements,

        too-many-boolean-expressions,

        consider-merging-isinstance,

        too-many-nested-blocks,

        simplifiable-if-statement,

        redefined-argument-from-local,

        no-else-return,

        consider-using-ternary,

        trailing-comma-tuple,

        stop-iteration-return,

        simplify-boolean-expression,

        inconsistent-return-statements,

        useless-return,

        consider-swap-variables,

        consider-using-join,

        consider-using-in,

        consider-using-get,

        chained-comparison,

        consider-using-dict-comprehension,

        consider-using-set-comprehension,

        simplifiable-if-expression,

        unreachable,

        dangerous-default-value,

        pointless-statement,

        pointless-string-statement,

        expression-not-assigned,

        unnecessary-pass,

        unnecessary-lambda,

        duplicate-key,

        assign-to-new-keyword,

        useless-else-on-loop,

        exec-used,

        eval-used,

        confusing-with-statement,

        using-constant-test,

        comparison-with-callable,

        lost-exception,

        assert-on-tuple,

        attribute-defined-outside-init,

        bad-staticmethod-argument,

        protected-access,

        arguments-differ,

        signature-differs,

        abstract-method,

        super-init-not-called,

        no-init,

        non-parent-init-called,

        useless-super-delegation,

        unnecessary-semicolon,

        bad-indentation,

        mixed-indentation,

        wildcard-import,

        deprecated-module,

        relative-import,

        reimported,

        import-self,

        misplaced-future,

        fixme,

        invalid-encoded-data,

        global-variable-undefined,

        global-variable-not-assigned,

        global-statement,

        global-at-module-level,

        unused-import,

        unused-variable,

        unused-argument,

        unused-wildcard-import,

        redefined-outer-name,

        redefined-builtin,

        redefine-in-handler,

        undefined-loop-variable,

        unbalanced-tuple-unpacking,

        cell-var-from-loop,

        possibly-unused-variable,

        self-cls-assignment,

        bare-except,

        broad-except,

        duplicate-except,

        try-except-raise,

        binary-op-exception,

        raising-format-tuple,

        keyword-arg-before-vararg,

        logging-not-lazy,

        logging-format-interpolation,

        logging-fstring-interpolation,

        bad-format-string-key,

        unused-format-string-key,

        bad-format-string,

        missing-format-argument-key,

        unused-format-string-argument,

        format-combined-specification,

        missing-format-attribute,

        invalid-format-index,

        duplicate-string-formatting-argument,

        anomalous-backslash-in-string,

        anomalous-unicode-escape-in-string,

        implicit-str-concat-in-sequence,

        bad-open-mode,

        boolean-datetime,

        redundant-unittest-assert,

        deprecated-method,

        bad-thread-instantiation,

        shallow-copy-environ,

        invalid-envvar-default,

        subprocess-popen-preexec-fn,

        apply-builtin,

        basestring-builtin,

        buffer-builtin,
@@ -139,21 +294,107 @@ disable=print-statement, 
        xreadlines-attribute,

        deprecated-sys-function,

        exception-escape,

        comprehension-escape,  # <-- End of defaults, rest added by AK

        no-else-return,

        missing-docstring,

        bad-continuation,

        invalid-name,

        useless-object-inheritance,

        exec-used,

        duplicate-code,

        too-few-public-methods,

        comprehension-escape



# Enable the message, report, category or checker with the given id(s). You can

# either give multiple identifier separated by comma (,) or put this option

# multiple time (only on the command line, not in the configuration file where

# it should appear only once). See also the "--disable" option for examples.

enable=c-extension-no-member

enable=syntax-error,

       unrecognized-inline-option,

       bad-option-value,

       init-is-generator,

       return-in-init,

       function-redefined,

       not-in-loop,

       return-outside-function,

       yield-outside-function,

       return-arg-in-generator,

       nonexistent-operator,

       duplicate-argument-name,

       abstract-class-instantiated,

       bad-reversed-sequence,

       too-many-star-expressions,

       invalid-star-assignment-target,

       star-needs-assignment-target,

       nonlocal-and-global,

       continue-in-finally,

       nonlocal-without-binding,

       used-prior-global-declaration,

       misplaced-format-function,

       method-hidden,

       access-member-before-definition,

       no-method-argument,

       no-self-argument,

       invalid-slots-object,

       assigning-non-slot,

       invalid-slots,

       inherit-non-class,

       inconsistent-mro,

       duplicate-bases,

       non-iterator-returned,

       unexpected-special-method-signature,

       invalid-length-returned,

       import-error,

       relative-beyond-top-level,

       used-before-assignment,

       undefined-variable,

       undefined-all-variable,

       invalid-all-object,

       no-name-in-module,

       unpacking-non-sequence,

       bad-except-order,

       raising-bad-type,

       bad-exception-context,

       misplaced-bare-raise,

       raising-non-exception,

       notimplemented-raised,

       catching-non-exception,

       bad-super-call,

       missing-super-argument,

       no-member,

       not-callable,

       assignment-from-no-return,

       no-value-for-parameter,

       too-many-function-args,

       unexpected-keyword-arg,

       redundant-keyword-arg,

       missing-kwoa,

       invalid-sequence-index,

       invalid-slice-index,

       assignment-from-none,

       not-context-manager,

       invalid-unary-operand-type,

       unsupported-binary-operation,

       repeated-keyword,

       not-an-iterable,

       not-a-mapping,

       unsupported-membership-test,

       unsubscriptable-object,

       unsupported-assignment-operation,

       unsupported-delete-operation,

       invalid-metaclass,

       unhashable-dict-key,

       logging-unsupported-format,

       logging-format-truncated,

       logging-too-many-args,

       logging-too-few-args,

       bad-format-character,

       truncated-format-string,

       mixed-format-string,

       format-needs-mapping,

       missing-format-string-key,

       too-many-format-args,

       too-few-format-args,

       bad-string-format-type,

       bad-str-strip-call,

       invalid-envvar-value,

       yield-inside-async-function,

       not-async-context-manager,

       fatal,

       astroid-error,

       parse-error,

       method-check-failed





[REPORTS]
@@ -195,11 +436,177 @@ never-returning-functions=sys.exit 


[LOGGING]



# Format style used to check logging format string. `old` means using %

# formatting, while `new` is for `{}` formatting.

logging-format-style=old



# Logging modules to check that the string format arguments are in logging

# function parameter format.

logging-modules=logging





[SPELLING]



# Limits count of emitted suggestions for spelling mistakes.

max-spelling-suggestions=4



# Spelling dictionary name. Available dictionaries: none. To make it working

# install python-enchant package..

spelling-dict=



# List of comma separated words that should not be checked.

spelling-ignore-words=



# A path to a file that contains private dictionary; one word per line.

spelling-private-dict-file=



# Tells whether to store unknown words to indicated private dictionary in

# --spelling-private-dict-file option instead of raising a message.

spelling-store-unknown-words=no





[MISCELLANEOUS]



# List of note tags to take in consideration, separated by a comma.

notes=FIXME,

      XXX,

      TODO





[TYPECHECK]



# List of decorators that produce context managers, such as

# contextlib.contextmanager. Add to this list to register other decorators that

# produce valid context managers.

contextmanager-decorators=contextlib.contextmanager



# List of members which are set dynamically and missed by pylint inference

# system, and so shouldn't trigger E1101 when accessed. Python regular

# expressions are accepted.

generated-members=



# Tells whether missing members accessed in mixin class should be ignored. A

# mixin class is detected if its name ends with "mixin" (case insensitive).

ignore-mixin-members=yes



# Tells whether to warn about missing members when the owner of the attribute

# is inferred to be None.

ignore-none=yes



# This flag controls whether pylint should warn about no-member and similar

# checks whenever an opaque object is returned when inferring. The inference

# can return multiple potential results while evaluating a Python object, but

# some branches might not be evaluated, which results in partial inference. In

# that case, it might be useful to still emit no-member and other checks for

# the rest of the inferred objects.

ignore-on-opaque-inference=yes



# List of class names for which member attributes should not be checked (useful

# for classes with dynamically set attributes). This supports the use of

# qualified names.

ignored-classes=optparse.Values,thread._local,_thread._local



# List of module names for which member attributes should not be checked

# (useful for modules/projects where namespaces are manipulated during runtime

# and thus existing member attributes cannot be deduced by static analysis. It

# supports qualified module names, as well as Unix pattern matching.

ignored-modules=



# Show a hint with possible names when a member name was not found. The aspect

# of finding the hint is based on edit distance.

missing-member-hint=yes



# The minimum edit distance a name should have in order to be considered a

# similar match for a missing member name.

missing-member-hint-distance=1



# The total number of similar names that should be taken in consideration when

# showing a hint for a missing member.

missing-member-max-choices=1





[VARIABLES]



# List of additional names supposed to be defined in builtins. Remember that

# you should avoid defining new builtins when possible.

additional-builtins=



# Tells whether unused global variables should be treated as a violation.

allow-global-unused-variables=yes



# List of strings which can identify a callback function by name. A callback

# name must start or end with one of those strings.

callbacks=cb_,

          _cb



# A regular expression matching the name of dummy variables (i.e. expected to

# not be used).

dummy-variables-rgx=_+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_



# Argument names that match this expression will be ignored. Default to name

# with leading underscore.

ignored-argument-names=_.*|^ignored_|^unused_



# Tells whether we should check for unused import in __init__ files.

init-import=no



# List of qualified module names which can have objects that can redefine

# builtins.

redefining-builtins-modules=six.moves,past.builtins,future.builtins,builtins,io





[FORMAT]



# Expected format of line ending, e.g. empty (any line ending), LF or CRLF.

expected-line-ending-format=



# Regexp for a line that is allowed to be longer than the limit.

ignore-long-lines=^\s*(# )?<?https?://\S+>?$



# Number of spaces of indent required inside a hanging or continued line.

indent-after-paren=4



# String used as indentation unit. This is usually "    " (4 spaces) or "\t" (1

# tab).

indent-string='    '



# Maximum number of characters on a single line.

max-line-length=100



# Maximum number of lines in a module.

max-module-lines=1000



# List of optional constructs for which whitespace checking is disabled. `dict-

# separator` is used to allow tabulation in dicts, etc.: {1  : 1,\n222: 2}.

# `trailing-comma` allows a space between comma and closing bracket: (a, ).

# `empty-line` allows space-only lines.

no-space-check=trailing-comma,

               dict-separator



# Allow the body of a class to be on the same line as the declaration if body

# contains single statement.

single-line-class-stmt=no



# Allow the body of an if to be on the same line as the test if there is no

# else.

single-line-if-stmt=no





[SIMILARITIES]



# Ignore comments when computing similarities.

ignore-comments=yes



# Ignore docstrings when computing similarities.

ignore-docstrings=yes



# Ignore imports when computing similarities.

ignore-imports=no



# Minimum lines number of a similarity.

min-similarity-lines=4





[BASIC]



# Naming style matching correct argument names.
@@ -298,6 +705,7 @@ no-docstring-rgx=^_ 


# List of decorators that produce properties, such as abc.abstractproperty. Add

# to this list to register other decorators that produce valid properties.

# These decorators are taken in consideration only for invalid-name.

property-classes=abc.abstractproperty



# Naming style matching correct variable names.
@@ -308,166 +716,59 @@ variable-naming-style=snake_case 
#variable-rgx=





[FORMAT]



# Expected format of line ending, e.g. empty (any line ending), LF or CRLF.

expected-line-ending-format=



# Regexp for a line that is allowed to be longer than the limit.

ignore-long-lines=^\s*(# )?<?https?://\S+>?$



# Number of spaces of indent required inside a hanging  or continued line.

indent-after-paren=4



# String used as indentation unit. This is usually "    " (4 spaces) or "\t" (1

# tab).

indent-string='    '



# Maximum number of characters on a single line.

max-line-length=100



# Maximum number of lines in a module.

max-module-lines=1000



# List of optional constructs for which whitespace checking is disabled. `dict-

# separator` is used to allow tabulation in dicts, etc.: {1  : 1,\n222: 2}.

# `trailing-comma` allows a space between comma and closing bracket: (a, ).

# `empty-line` allows space-only lines.

no-space-check=trailing-comma,

               dict-separator



# Allow the body of a class to be on the same line as the declaration if body

# contains single statement.

single-line-class-stmt=no



# Allow the body of an if to be on the same line as the test if there is no

# else.

single-line-if-stmt=no





[VARIABLES]



# List of additional names supposed to be defined in builtins. Remember that

# you should avoid to define new builtins when possible.

additional-builtins=



# Tells whether unused global variables should be treated as a violation.

allow-global-unused-variables=yes



# List of strings which can identify a callback function by name. A callback

# name must start or end with one of those strings.

callbacks=cb_,

          _cb



# A regular expression matching the name of dummy variables (i.e. expected to

# not be used).

dummy-variables-rgx=_+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_



# Argument names that match this expression will be ignored. Default to name

# with leading underscore.

ignored-argument-names=_.*|^ignored_|^unused_



# Tells whether we should check for unused import in __init__ files.

init-import=no



# List of qualified module names which can have objects that can redefine

# builtins.

redefining-builtins-modules=six.moves,past.builtins,future.builtins,builtins,io





[SIMILARITIES]



# Ignore comments when computing similarities.

ignore-comments=yes



# Ignore docstrings when computing similarities.

ignore-docstrings=yes



# Ignore imports when computing similarities.

ignore-imports=no



# Minimum lines number of a similarity.

min-similarity-lines=4





[MISCELLANEOUS]



# List of note tags to take in consideration, separated by a comma.

notes=FIXME,

      XXX,

      TODO





[TYPECHECK]



# List of decorators that produce context managers, such as

# contextlib.contextmanager. Add to this list to register other decorators that

# produce valid context managers.

contextmanager-decorators=contextlib.contextmanager



# List of members which are set dynamically and missed by pylint inference

# system, and so shouldn't trigger E1101 when accessed. Python regular

# expressions are accepted.

generated-members=



# Tells whether missing members accessed in mixin class should be ignored. A

# mixin class is detected if its name ends with "mixin" (case insensitive).

ignore-mixin-members=yes

[IMPORTS]



# Tells whether to warn about missing members when the owner of the attribute

# is inferred to be None.

ignore-none=yes

# Allow wildcard imports from modules that define __all__.

allow-wildcard-with-all=no



# This flag controls whether pylint should warn about no-member and similar

# checks whenever an opaque object is returned when inferring. The inference

# can return multiple potential results while evaluating a Python object, but

# some branches might not be evaluated, which results in partial inference. In

# that case, it might be useful to still emit no-member and other checks for

# the rest of the inferred objects.

ignore-on-opaque-inference=yes

# Analyse import fallback blocks. This can be used to support both Python 2 and

# 3 compatible code, which means that the block might have code that exists

# only in one or another interpreter, leading to false positives when analysed.

analyse-fallback-blocks=no



# List of class names for which member attributes should not be checked (useful

# for classes with dynamically set attributes). This supports the use of

# qualified names.

ignored-classes=optparse.Values,thread._local,_thread._local

# Deprecated modules which should not be used, separated by a comma.

deprecated-modules=optparse,tkinter.tix



# List of module names for which member attributes should not be checked

# (useful for modules/projects where namespaces are manipulated during runtime

# and thus existing member attributes cannot be deduced by static analysis. It

# supports qualified module names, as well as Unix pattern matching.

ignored-modules=

# Create a graph of external dependencies in the given file (report RP0402 must

# not be disabled).

ext-import-graph=



# Show a hint with possible names when a member name was not found. The aspect

# of finding the hint is based on edit distance.

missing-member-hint=yes

# Create a graph of every (i.e. internal and external) dependencies in the

# given file (report RP0402 must not be disabled).

import-graph=



# The minimum edit distance a name should have in order to be considered a

# similar match for a missing member name.

missing-member-hint-distance=1

# Create a graph of internal dependencies in the given file (report RP0402 must

# not be disabled).

int-import-graph=



# The total number of similar names that should be taken in consideration when

# showing a hint for a missing member.

missing-member-max-choices=1

# Force import order to recognize a module as part of the standard

# compatibility libraries.

known-standard-library=



# Force import order to recognize a module as part of a third party library.

known-third-party=enchant



[SPELLING]



# Limits count of emitted suggestions for spelling mistakes.

max-spelling-suggestions=4

[CLASSES]



# Spelling dictionary name. Available dictionaries: none. To make it working

# install python-enchant package..

spelling-dict=

# List of method names used to declare (i.e. assign) instance attributes.

defining-attr-methods=__init__,

                      __new__,

                      setUp



# List of comma separated words that should not be checked.

spelling-ignore-words=

# List of member names, which should be excluded from the protected access

# warning.

exclude-protected=_asdict,

                  _fields,

                  _replace,

                  _source,

                  _make



# A path to a file that contains private dictionary; one word per line.

spelling-private-dict-file=

# List of valid names for the first argument in a class method.

valid-classmethod-first-arg=cls



# Tells whether to store unknown words to indicated private dictionary in

# --spelling-private-dict-file option instead of raising a message.

spelling-store-unknown-words=no

# List of valid names for the first argument in a metaclass class method.

valid-metaclass-classmethod-first-arg=cls





[DESIGN]
@@ -503,61 +804,6 @@ max-statements=50 
min-public-methods=2





[CLASSES]



# List of method names used to declare (i.e. assign) instance attributes.

defining-attr-methods=__init__,

                      __new__,

                      setUp



# List of member names, which should be excluded from the protected access

# warning.

exclude-protected=_asdict,

                  _fields,

                  _replace,

                  _source,

                  _make



# List of valid names for the first argument in a class method.

valid-classmethod-first-arg=cls



# List of valid names for the first argument in a metaclass class method.

valid-metaclass-classmethod-first-arg=cls





[IMPORTS]



# Allow wildcard imports from modules that define __all__.

allow-wildcard-with-all=no



# Analyse import fallback blocks. This can be used to support both Python 2 and

# 3 compatible code, which means that the block might have code that exists

# only in one or another interpreter, leading to false positives when analysed.

analyse-fallback-blocks=no



# Deprecated modules which should not be used, separated by a comma.

deprecated-modules=optparse,tkinter.tix



# Create a graph of external dependencies in the given file (report RP0402 must

# not be disabled).

ext-import-graph=



# Create a graph of every (i.e. internal and external) dependencies in the

# given file (report RP0402 must not be disabled).

import-graph=



# Create a graph of internal dependencies in the given file (report RP0402 must

# not be disabled).

int-import-graph=



# Force import order to recognize a module as part of the standard

# compatibility libraries.

known-standard-library=



# Force import order to recognize a module as part of a third party library.

known-third-party=enchant





[EXCEPTIONS]



# Exceptions that will emit a warning when being caught. Defaults to